fix(client-preset): allow non-typescript plugins (#8523)

dotansimha · Oct 25, 2022 · 3a3202f · 3a3202f
1 parent cb44490
commit 3a3202f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/fair-mugs-reflect.md b/.changeset/fair-mugs-reflect.md
@@ -0,0 +1,5 @@
+---
+'@graphql-codegen/client-preset': patch
+---
+
+allow non-typescript plugins
diff --git a/packages/presets/client/src/index.ts b/packages/presets/client/src/index.ts
@@ -73,8 +73,10 @@ export const preset: Types.OutputPreset<ClientPresetConfig> = {
       throw new Error('[client-preset] target output should be a directory, ex: "src/gql/"');
     }
 
-    if (options.plugins.length > 0) {
-      throw new Error('[client-preset] providing `plugins` with `preset: "client" leads to duplicated generated types');
+    if (options.plugins.length > 0 && Object.keys(options.plugins).some(p => p.startsWith('typescript'))) {
+      throw new Error(
+        '[client-preset] providing typescript-based `plugins` with `preset: "client" leads to duplicated generated types'
+      );
     }
 
     const reexports: Array<string> = [];