-
Notifications
You must be signed in to change notification settings - Fork 480
chore(style-editor): Implement optimistic updates for real time headless rendering #34208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
KevinDavilaDotCMS
merged 13 commits into
main
from
34085-task-implement-optimistic-updates-in-style-editor-for-real-time-headless-rendering-II
Jan 7, 2026
Merged
chore(style-editor): Implement optimistic updates for real time headless rendering #34208
KevinDavilaDotCMS
merged 13 commits into
main
from
34085-task-implement-optimistic-updates-in-style-editor-for-real-time-headless-rendering-II
Jan 7, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
…chine functionality and code cleanup - Added time machine capabilities to manage state history for optimistic updates in the style editor. - Cleaned up code formatting and ensured consistent use of semicolons and newlines across various files. These changes improve the maintainability and functionality of the style editor, allowing for better state management and user experience.
…gement - Refactored the style editor form component to utilize a dedicated form builder service, enhancing form creation and management. - Removed unused imports and cleaned up code for better readability. - Updated methods for extracting and updating style properties to streamline functionality and improve performance. - Ensured consistent handling of form values during rollback operations. These changes enhance the maintainability and efficiency of the style editor, providing a more robust user experience.
…nger import - Removed the test button from the edit-ema editor component to streamline the UI. - Updated the import path for the UveIframeMessengerService to reflect its new location. - Cleaned up console log statements in the contentlet tools component for better code clarity. - Adjusted style properties handling in the GraphQL utility functions for consistency. These changes enhance the maintainability of the code and improve the overall user experience in the edit-ema editor.
- Removed unused imports from the edit-ema editor component and style editor form builder service for improved clarity. - Updated import paths for consistency across components, ensuring better maintainability. - Streamlined the GraphQL utility functions by adjusting import statements, enhancing code readability. These changes contribute to a cleaner codebase and facilitate easier future modifications.
…tyle-editor-for-real-time-headless-rendering
…e and debounce functionality - Integrated MessageService for user notifications on style property saves, improving user feedback. - Implemented a debounce mechanism for form value changes to optimize performance and reduce unnecessary API calls. - Updated variable names for consistency and clarity, ensuring better maintainability. - Cleaned up code and imports across the style editor component and related files. These changes enhance the user experience and performance of the style editor, providing timely feedback and efficient state management.
…tyle-editor-for-real-time-headless-rendering
- Enhanced GraphQLResponse type to utilize DotCMSPageResponse for better type safety and clarity. - Adjusted SaveStylePropertiesPayload interface to reorder properties for consistency. - Improved formatting of DialogAction interface for better readability. These changes aim to improve code maintainability and type accuracy in the style editor component.
5 tasks
dario-daza
reviewed
Jan 6, 2026
dario-daza
approved these changes
Jan 6, 2026
5 tasks
…form - Introduced linkedSignal for tracking rollback detection based on currentIndex. - Updated rollback detection logic to simplify form restoration on index decrease. - Enhanced error handling in the save function to log errors during style property saves. These changes improve the functionality and reliability of the style editor, ensuring better user experience during undo operations.
zJaaal
approved these changes
Jan 6, 2026
rjvelazco
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
style.editor.mechanis.mov
This PR fixes: #34085