Conversation
…ol visibility logic
…proved editing experience
…nav-trigger-in-uve
…nd improve UI responsiveness
...et/src/lib/edit-ema-editor/components/ema-contentlet-tools/ema-contentlet-tools.component.ts
Outdated
Show resolved
Hide resolved
…, enhancing contentlet management features
…ance drag-and-drop functionality
…selection feature
...ib/edit-ema-editor/components/dot-uve-contentlet-tools/dot-uve-contentlet-tools.component.ts
Show resolved
Hide resolved
...it-ema-editor/components/dot-uve-contentlet-tools/dot-uve-contentlet-tools.component.spec.ts
Show resolved
Hide resolved
|
Semgrep found 2
Risk: Affected versions of @angular/compiler are vulnerable to Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting'). A stored XSS vulnerability in the Angular Template Compiler arises because its internal security schema doesn't classify certain URL‐ holding attributes (e.g. xlink:href, math|href, annotation|href) or the Manual Review Advice: A vulnerability from this advisory is reachable if you allow Fix: Upgrade this library to at least version 20.3.15 at core/core-web/yarn.lock:557. Reference(s): GHSA-v4hv-rgfq-gp49, CVE-2025-66412 If this is a critical or high severity finding, please also link this issue in the #security channel in Slack. |
...-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-palette/dot-uve-palette.component.ts
Show resolved
Hide resolved
...it-ema-editor/components/dot-uve-contentlet-tools/dot-uve-contentlet-tools.component.spec.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
This PR implements a Style Editor sidenav trigger in the Universal Visual Editor (UVE), introducing a new tab in the palette for styling contentlets. The implementation includes significant refactoring of the contentlet tools component and state management.
Key Changes:
- Added new Style Editor tab to the UVE palette with feature flag support
- Refactored contentlet controls from
EmaContentletToolsComponenttoDotUveContentletToolsComponentwith improved architecture - Introduced
withPageContextfeature to centralize common computed signals across the store - Added support for registering and selecting contentlets to trigger style editing
Reviewed changes
Copilot reviewed 44 out of 45 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
core-web/libs/sdk/types/src/lib/editor/public.ts |
Added REGISTER_STYLE_SCHEMAS action enum for style editor integration |
core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/withPageContext.ts |
New feature consolidating shared computed signals like $isPageLocked, $canEditPage, $isStyleEditorEnabled |
core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/models.ts |
Added StyleSchema interface, UVE_PALETTE_TABS enum, and refactored palette state structure |
core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/withEditor.ts |
Major refactor: added $styleSchema, $showContentletControls, $allowContentDelete computeds; updated palette structure |
core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/load/withLoad.ts |
Removed duplicate canEditPage and pageIsLocked computation (now in withPageContext) |
core-web/libs/portlets/edit-ema/portlet/src/lib/store/dot-uve.store.ts |
Integrated withPageContext feature and removed duplicate computed signals |
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.ts |
Added style editor triggers, contentlet selection, drag image handling, and iframe resize observer |
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-contentlet-tools/* |
Complete rewrite of contentlet tools component with better signal-based architecture |
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-palette/* |
Added Style Editor tab with feature flag, updated to use controlled activeTab input |
core-web/libs/portlets/edit-ema/portlet/src/lib/utils/index.ts |
Renamed computePageIsLocked to computeIsPageLocked for better naming consistency |
| Test files | Comprehensive test updates reflecting component and state management refactoring |
Comments suppressed due to low confidence (1)
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-contentlet-tools/dot-uve-contentlet-tools.component.scss:49
- The
pointer-events: allproperty is duplicated on lines 46 and 48 for the same selectors. Remove one of the duplicate declarations.
core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/models.ts
Show resolved
Hide resolved
core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/withEditor.ts
Show resolved
Hide resolved
...-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-palette/dot-uve-palette.component.ts
Outdated
Show resolved
Hide resolved
...-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-palette/dot-uve-palette.component.ts
Outdated
Show resolved
Hide resolved
...ib/edit-ema-editor/components/dot-uve-contentlet-tools/dot-uve-contentlet-tools.component.ts
Outdated
Show resolved
Hide resolved
...ib/edit-ema-editor/components/dot-uve-contentlet-tools/dot-uve-contentlet-tools.component.ts
Outdated
Show resolved
Hide resolved
core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/withEditor.spec.ts
Outdated
Show resolved
Hide resolved
...ib/edit-ema-editor/components/dot-uve-contentlet-tools/dot-uve-contentlet-tools.component.ts
Outdated
Show resolved
Hide resolved
...ib/edit-ema-editor/components/dot-uve-contentlet-tools/dot-uve-contentlet-tools.component.ts
Outdated
Show resolved
Hide resolved
...-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-palette/dot-uve-palette.component.ts
Outdated
Show resolved
Hide resolved
...t-uve-toolbar/components/dot-uve-workflow-actions/dot-uve-workflow-actions.component.spec.ts
Show resolved
Hide resolved
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.html
Show resolved
Hide resolved
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.ts
Show resolved
Hide resolved
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.ts
Outdated
Show resolved
Hide resolved
core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/editor/withEditor.ts
Outdated
Show resolved
Hide resolved
core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/withPageContext.ts
Show resolved
Hide resolved
...ib/edit-ema-editor/components/dot-uve-contentlet-tools/dot-uve-contentlet-tools.component.ts
Outdated
Show resolved
Hide resolved
...ib/edit-ema-editor/components/dot-uve-contentlet-tools/dot-uve-contentlet-tools.component.ts
Outdated
Show resolved
Hide resolved
...-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-palette/dot-uve-palette.component.ts
Show resolved
Hide resolved
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.scss
Outdated
Show resolved
Hide resolved
.../edit-ema-editor/components/dot-uve-contentlet-tools/dot-uve-contentlet-tools.component.scss
Show resolved
Hide resolved
...ib/edit-ema-editor/components/dot-uve-contentlet-tools/dot-uve-contentlet-tools.component.ts
Outdated
Show resolved
Hide resolved
...ib/edit-ema-editor/components/dot-uve-contentlet-tools/dot-uve-contentlet-tools.component.ts
Outdated
Show resolved
Hide resolved
...ma/portlet/src/lib/edit-ema-editor/components/dot-uve-palette/dot-uve-palette.component.html
Show resolved
Hide resolved
...ma/portlet/src/lib/edit-ema-editor/components/dot-uve-palette/dot-uve-palette.component.html
Show resolved
Hide resolved
...portlet/src/lib/edit-ema-editor/components/dot-uve-palette/dot-uve-palette.component.spec.ts
Outdated
Show resolved
Hide resolved
…-in-uve' of https://github.com/dotCMS/core into issue-33997-task-implement-style-editor-sidenav-trigger-in-uve
Video
video.mov
This PR fixes: #33997
This PR fixes: #33997