Skip to content

fix(uve): Update toolbar dropdown messages #31291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 5, 2025
Merged

fix(uve): Update toolbar dropdown messages #31291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eccfc71
Added new translations
kevindaviladev Jan 31, 2025
781771d
Added new translations
kevindaviladev Jan 31, 2025
e27f030
Removed unused folder
kevindaviladev Jan 31, 2025
8077092
Fixed tests
kevindaviladev Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...ve-toolbar/components/dot-editor-mode-selector/dot-editor-mode-selector.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,8 @@ describe('DotEditorModeSelectorComponent', () => {
test.each([
{
mode: UVE_MODE.EDIT,
label: 'uve.editor.mode.edit',
description: 'uve.editor.mode.edit.description'
label: 'uve.editor.mode.draft',
description: 'uve.editor.mode.draft.description'
},
{
mode: UVE_MODE.PREVIEW,
Expand All @@ -229,8 +229,8 @@ describe('DotEditorModeSelectorComponent', () => {
},
{
mode: UVE_MODE.LIVE,
label: 'uve.editor.mode.live',
description: 'uve.editor.mode.live.description'
label: 'uve.editor.mode.published',
description: 'uve.editor.mode.published.description'
}
])(
'should show correct label and description for $mode menu item',
Expand All @@ -247,9 +247,9 @@ describe('DotEditorModeSelectorComponent', () => {
);

test.each([
{ mode: UVE_MODE.EDIT, label: 'uve.editor.mode.edit' },
{ mode: UVE_MODE.EDIT, label: 'uve.editor.mode.draft' },
{ mode: UVE_MODE.PREVIEW, label: 'uve.editor.mode.preview' },
{ mode: UVE_MODE.LIVE, label: 'uve.editor.mode.live' }
{ mode: UVE_MODE.LIVE, label: 'uve.editor.mode.published' }
])('should update button label when mode changes - $mode', ({ mode, label }) => {
// Start with Edit mode
mockStore.pageParams.set({ ...pageParams, editorMode: mode });
Expand Down
8 changes: 4 additions & 4 deletions ...dot-uve-toolbar/components/dot-editor-mode-selector/dot-editor-mode-selector.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ export class DotEditorModeSelectorComponent {

if (canEditPage) {
menu.push({
label: 'uve.editor.mode.edit',
description: 'uve.editor.mode.edit.description',
label: 'uve.editor.mode.draft',
description: 'uve.editor.mode.draft.description',
id: UVE_MODE.EDIT
});
}
Expand All @@ -49,8 +49,8 @@ export class DotEditorModeSelectorComponent {

if (hasLiveVersion) {
menu.push({
label: 'uve.editor.mode.live',
description: 'uve.editor.mode.live.description',
label: 'uve.editor.mode.published',
description: 'uve.editor.mode.published.description',
id: UVE_MODE.LIVE
});
}
Expand Down
10 changes: 5 additions & 5 deletions dotCMS/src/main/webapp/WEB-INF/messages/Language.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5929,12 +5929,12 @@ uve.preview.mode.social.media.subheader=Social Media Tiles
uve.preview.mode.search.engine.subheader=Search Engine
uve.disable.delete.button.on.personalization=Personalization requires a minimum of <b>one</b> content item.
uve.personalize.empty.page.error=Personalization requires page content. Add some first.
uve.editor.mode.edit=Edit
uve.editor.mode.draft=Draft
uve.editor.mode.preview=Preview
uve.editor.mode.live=Live
uve.editor.mode.edit.description=Edit the page
uve.editor.mode.preview.description=Preview the current page
uve.editor.mode.live.description=Preview the current and future versions of the page
uve.editor.mode.published=Live
uve.editor.mode.draft.description=Edit your page
uve.editor.mode.preview.description=Check your latest edits
uve.editor.mode.published.description=View live or future page


coming.soon=Coming Soon
Expand Down
Loading