fix(perf) don't create session if it is not required #30322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve session handling in the
CurrentVariantWebInterceptor
andVariantWebAPIImpl
classes. The main focus is on ensuring sessions are only created when necessary, which can help optimize resource usage and performance.Session handling improvements:
dotCMS/src/main/java/com/dotcms/variant/business/web/CurrentVariantWebInterceptor.java
: ModifiedgetSession
to avoid creating a new session if one does not already exist by passingfalse
togetSession
.dotCMS/src/main/java/com/dotcms/variant/business/web/VariantWebAPIImpl.java
: RenamedsetSessionAttribute
tosetSessionAttributeIfNeeded
and updated the method to conditionally create a session based on thecurrentVariantName
.This PR fixes: #30321