Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CDI) Refs: #29552 #29678

Merged
merged 23 commits into from
Aug 29, 2024
Merged

feat(CDI) Refs: #29552 #29678

merged 23 commits into from
Aug 29, 2024

Conversation

fabrizzio-dotCMS
Copy link
Contributor

@fabrizzio-dotCMS fabrizzio-dotCMS commented Aug 20, 2024 •
edited by github-actions bot
Loading

Proposed Changes

  • In this PR we are upgrading to jersey 2.28
  • We are changing DotRestApplication to use package discovery to load Resources and Providers
  • We're making some adjustments on some Mappers to preserve the present behavior
  • We're introducing CDI through Weld container

This PR fixes: #29552

@fabrizzio-dotCMS fabrizzio-dotCMS changed the title #29552 feat(CDI) Refs: #29552 Aug 23, 2024
@fabrizzio-dotCMS fabrizzio-dotCMS marked this pull request as ready for review August 23, 2024 20:30
@fabrizzio-dotCMS fabrizzio-dotCMS linked an issue Aug 28, 2024 that may be closed by this pull request
Enable CDI : Timebox - Check if existing work can be easily merged now #29552
Closed
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
13 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@fabrizzio-dotCMS fabrizzio-dotCMS added this pull request to the merge queue Aug 29, 2024
Merged via the queue into master with commit 11358b0 Aug 29, 2024
31 checks passed
@fabrizzio-dotCMS fabrizzio-dotCMS deleted the issue-29552-enable-cdi-refine2 branch August 29, 2024 16:47
fabrizzio-dotCMS added a commit that referenced this pull request Aug 30, 2024
@fabrizzio-dotCMS
Revert "feat(CDI) Refs: #29552 (#29678)"
5914caf 
This reverts commit 11358b0.
github-merge-queue bot pushed a commit that referenced this pull request Aug 30, 2024
@fabrizzio-dotCMS
Revert "feat(CDI) Refs: #29552 (#29678)" (#29800)
dd2581f 
This reverts commit 11358b0.

This change breaks the API Playground 
as it adds an extra API prefix to the URLs like this:


http://localhost:8080/api/api/v1/contenttype?orderby=upper%28name%29&direction=ASC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgambarios jgambarios jgambarios approved these changes

@spbolton spbolton spbolton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable CDI : Timebox - Check if existing work can be easily merged now
3 participants
@fabrizzio-dotCMS @jgambarios @spbolton