#29281: returning available models as object that includes 'name' and 'type' instead of just a list os strings #29549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcastro-dotcms
approved these changes
Aug 13, 2024
jdotcms
reviewed
Aug 13, 2024
jdotcms
reviewed
Aug 13, 2024
jdotcms
reviewed
Aug 13, 2024
victoralfaro-dotcms
force-pushed
the
29281-return-object-available-model
branch
from
655c96a
to
e2c1a0e
Compare
…d 'type' instead of just a list os strings
…reak the tests when any of AI API url or AI API key are missing. Clean the default values for model names and max tokens are now required.
victoralfaro-dotcms
force-pushed
the
29281-return-object-available-model
branch
2 times, most recently
from
72baeab
to
c95d875
Compare
victoralfaro-dotcms
force-pushed
the
29281-return-object-available-model
branch
from
c95d875
to
3b8be74
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a
List<String>we now return aList<SimpleModel>which, for now, containsnameandtypeso this information can be consumed by other components such as the UI.