Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CLI) WatchMode Fix Refs: #28593 #29067

Merged
merged 15 commits into from
Jul 4, 2024
Merged

fix(CLI) WatchMode Fix Refs: #28593 #29067

merged 15 commits into from
Jul 4, 2024

Conversation

fabrizzio-dotCMS
Copy link
Contributor

@fabrizzio-dotCMS fabrizzio-dotCMS commented Jun 28, 2024 •
edited by github-actions bot
Loading

Proposed Changes

  • We're not handling relative paths very well
  • This should detect when a relative path is passed and attempt to solve it against the current dir
  • To test a relative path passed to Push I had to make push commands aware of the workspace because before it would depend on the path param. The working directory was either resolved using the path param when an absolute path would get passed or assuming the current directory was the workspace.

This PR fixes: #28593

@fabrizzio-dotCMS fabrizzio-dotCMS marked this pull request as ready for review July 2, 2024 22:57
@fabrizzio-dotCMS fabrizzio-dotCMS changed the title #28593 fix(CLI) WatchMode Fix Refs: #28593 Jul 3, 2024
@fabrizzio-dotCMS fabrizzio-dotCMS linked an issue Jul 3, 2024 that may be closed by this pull request
File System Watcher #28593
Closed
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
2 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@fabrizzio-dotCMS fabrizzio-dotCMS added this pull request to the merge queue Jul 3, 2024
Merged via the queue into master with commit dcfa034 Jul 4, 2024
18 checks passed
@fabrizzio-dotCMS fabrizzio-dotCMS deleted the issue-28593-file-watch branch July 4, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgambarios jgambarios jgambarios approved these changes

@valentinogiardino valentinogiardino valentinogiardino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File System Watcher
3 participants
@fabrizzio-dotCMS @jgambarios @valentinogiardino