chore(security) #28388 : XML External Entity (XXE) Injection in JDOM #29006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdotcms
reviewed
Jun 25, 2024
dotCMS/src/main/java/com/dotmarketing/business/portal/DotPortlet.java
Outdated
Show resolved
Hide resolved
dsilvam
approved these changes
Jun 25, 2024
jdotcms
approved these changes
Jun 25, 2024
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
oidacra
pushed a commit
that referenced
this pull request
Jun 26, 2024
…29006) ### Proposed Changes * Removes the use of the JDOM library altogether. * The classes using the JDOM library living under the `dotCMS/src/main/java/org/apache/velocity/anakia/` and `dotcms-integration/src/test/java/com/ettrema/` packages were removed altogether as well. * As per Steve Bolton's suggestion, we're now using the JAXB library to handle XML data representing Portlets in dotCMS. This includes both the Portlets defined in the `/WEB-INF/portlet.xml` and `/WEB-INF/portlet-ext.xml` files, and the database. * Additional Javadoc and code refactoring was done. * The `dotcms-postman/src/main/resources/postman/PortletResource.json` Postman suite was refactored to use JWT, organized into folders, and reviewed t make sure that the REST Endpoint is tested as much as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
dotCMS/src/main/java/org/apache/velocity/anakia/anddotcms-integration/src/test/java/com/ettrema/packages were removed altogether as well./WEB-INF/portlet.xmland/WEB-INF/portlet-ext.xmlfiles, and the database.dotcms-postman/src/main/resources/postman/PortletResource.jsonPostman suite was refactored to use JWT, organized into folders, and reviewed t make sure that the REST Endpoint is tested as much as possible.This PR fixes: #28388