Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: base image build tag needs prefix for push (27998) #28971

Merged
merged 1 commit into from
Jun 21, 2024
Merged

ci: base image build tag needs prefix for push (27998) #28971

merged 1 commit into from
Jun 21, 2024

Conversation

spbolton
Copy link
Contributor

@spbolton spbolton commented Jun 21, 2024 •
edited by github-actions bot
Loading

Proposed Changes

  • The base image needs to use the sdkman version as its tag, but the github action requires the image name to be prefixed to be able to push e.g. dotcms/java-base:11.0.22-ms and not just 11.0.22-ms

Relates to #27998 and found after this previous PR #28938

This PR fixes: #27998

@spbolton spbolton requested a review from a team as a code owner June 21, 2024 13:33
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@spbolton spbolton enabled auto-merge June 21, 2024 15:36
@spbolton spbolton added this pull request to the merge queue Jun 21, 2024
@nollymar nollymar linked an issue Jun 21, 2024 that may be closed by this pull request
Task: Update Workflow to Support Any Java Version Using SDKMAN #27998
Closed
4 tasks
Merged via the queue into master with commit bbb39f0 Jun 21, 2024
15 checks passed
@spbolton spbolton deleted the issue-27998-use-sdkman-for-java-in-ci-workflows-and-use-consis branch June 21, 2024 17:09
oidacra pushed a commit that referenced this pull request Jun 26, 2024
@spbolton @oidacra
ci: base image build tag needs prefix for push (27998) (#28971)
22a1387 
### Proposed Changes
* The base image needs to use the sdkman version as its tag, but the
github action requires the image name to be prefixed to be able to push
e.g. dotcms/java-base:11.0.22-ms and not just 11.0.22-ms

Relates to #27998 and found after this previous PR
#28938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgambarios jgambarios jgambarios approved these changes

@nollymar nollymar nollymar approved these changes

@fabrizzio-dotCMS fabrizzio-dotCMS fabrizzio-dotCMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task: Update Workflow to Support Any Java Version Using SDKMAN
4 participants
@spbolton @jgambarios @nollymar @fabrizzio-dotCMS