build: Use consistent java versions using sdkman #28868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
spbolton
force-pushed
the
issue-27998-task-update-workflow-to-support-any-java-version
branch
5 times, most recently
from
ae0ed22
to
50b57c1
Compare
spbolton
force-pushed
the
issue-27998-task-update-workflow-to-support-any-java-version
branch
from
50b57c1
to
6dd0970
Compare
|
dcolina
approved these changes
Jun 17, 2024
dcolina
approved these changes
Jun 17, 2024
wezell
approved these changes
Jun 17, 2024
spbolton
deleted the
issue-27998-task-update-workflow-to-support-any-java-version
branch
oidacra
pushed a commit
that referenced
this pull request
Jun 26, 2024
### Proposed Changes * Change java base image to use sdkman to get java version. Use SDKMAN_JAVA_VERSION build arg to specify SDKMAN version and implementation. * Create manual workflow specifically for creating java base image based upon SDKMAN version string being tagged and pushed with that version. * Modify maven to pick up version specified in ~/.sdkmanrc and use that by default to specify which upstream java base image to used. * Cleanup places where java version is specified in maven pom files to default to a single location in parent/pom.xml. Set default value in environments/environment.properties so it can be modified locally be developers easily and changed in one place. setting java.compat.version=11 * Use independent version for compatibility of build allowing Java 21 to be upgraded to but still allowing plugins to be build with Java 11 with easy switch later. * Cleanup DockerFiles with some AI help. Note: * This change does not actually update to java 21 yet. We should do internal test to upgrade to latest point release of java 11 first. e.g. 11.0.22-ms -> 11.0.23-ms * This change does not modify the version used in the ci build workflows. We will follow up a change to enable consistent use of the .sdkmanrc in the workflows after this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Note: