feat(edit content) #27289 : Add a button to the Content Type screen to enable the new edit mode #27333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o enable the new edit mode
…een-enable-new-edit-mode
…een-enable-new-edit-mode
erickgonzalez
approved these changes
Jan 16, 2024
AndreyDotcms
approved these changes
Jan 16, 2024
dotCMS/src/main/java/com/dotmarketing/portlets/structure/model/Structure.java
Outdated
Show resolved
Hide resolved
dotCMS/src/main/java/com/dotmarketing/portlets/structure/model/Structure.java
Outdated
Show resolved
Hide resolved
jdotcms
approved these changes
Jan 16, 2024
…een-enable-new-edit-mode
…een-enable-new-edit-mode
zJaaal
approved these changes
Jan 22, 2024
oidacra
approved these changes
Jan 22, 2024
rjvelazco
approved these changes
Jan 22, 2024
|
@hmoreras conflictos :D |
…een-enable-new-edit-mode
fmontes
requested changes
Jan 23, 2024
...app/portlets/shared/dot-content-types-edit/components/form/content-types-form.component.scss
Outdated
Show resolved
Hide resolved
core-web/libs/dotcms-scss/angular/dotcms-theme/components/form/_checkbox.scss
Outdated
Show resolved
Hide resolved
| @@ -83,7 +83,7 @@ export class DotEditContentFormComponent implements OnInit { | |||
| this.onFormChange(value); | |||
| }); | |||
|
|
|||
| this.formData.fields.forEach((field) => { | |||
| this.formData.contentType.fields.forEach((field) => { | |||
There was a problem hiding this comment.
Does this mean that we are passing fields twice? formData.fields and formData.contentType.fields?
There was a problem hiding this comment.
Because a change in EditContentPayload before in that interface we had a property called layout fields and contentType this last one as a string refereing to the conten type variable. All this props are actually in one single object, DotCMSContentType, so move that to a single prop.
core-web/libs/edit-content/src/lib/feature/edit-content/edit-content.layout.component.scss
Outdated
Show resolved
Hide resolved
…een-enable-new-edit-mode
…een-enable-new-edit-mode
…een-enable-new-edit-mode
fmontes
approved these changes
Jan 24, 2024
…een-enable-new-edit-mode
|
2.7% Coverage on New Code
0.0% Duplication on New Code…f the `metadata` column
|
Closing this PR as the merge with the latest master caused several files to go missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
structuretable calledmetadatathat will allow us to add any sort of permanent or temporary configuration parameters for every Content Type.Add bars to the edit content type dialog and the new edit content screen when the feature flag is on.
Screenshare.-.2024-01-19.10_24_42.PM.mp4