chore(edit-content): Use DotContentletThumbnail Component in Binary File #27321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…binary-preview-punchlist-use-web-component
rjvelazco
requested review from
fmontes,
zJaaal,
oidacra and
KevinDavilaDotCMS
and removed request for
fmontes
…binary-preview-punchlist-use-web-component
zJaaal
requested changes
Jan 12, 2024
...libs/dotcms-webcomponents/src/elements/dot-contentlet-thumbnail/dot-contentlet-thumbnail.tsx
Outdated
Show resolved
Hide resolved
…binary-preview-punchlist-use-web-component
...ent-binary-field/components/dot-binary-field-preview/dot-binary-field-preview.component.html
Outdated
Show resolved
Hide resolved
…w-punchlist-use-web-component' of https://github.com/dotCMS/core into issue-26907-edit-content-thumbnail-in-the-binary-preview-punchlist-use-web-component
fmontes
requested changes
Jan 12, 2024
core-web/libs/dotcms-webcomponents/src/elements/dot-video-thumbnail/dot-video-thumbnail.tsx
Show resolved
Hide resolved
...ent-binary-field/components/dot-binary-field-preview/dot-binary-field-preview.component.html
Outdated
Show resolved
Hide resolved
...-web/libs/ui/src/lib/components/dot-temp-file-thumbnail/dot-temp-file-thumbnail.component.ts
Show resolved
Hide resolved
|
KevinDavilaDotCMS
approved these changes
Jan 12, 2024
zJaaal
approved these changes
Jan 16, 2024
fmontes
approved these changes
Jan 16, 2024
oidacra
reviewed
Jan 16, 2024
| @@ -352,6 +352,7 @@ export namespace Components { | |||
| "cover": boolean; | |||
| "height": string; | |||
| "iconSize": string; | |||
| "playableVideo": boolean; | |||
oidacra
approved these changes
Jan 16, 2024
fmontes
deleted the
issue-26907-edit-content-thumbnail-in-the-binary-preview-punchlist-use-web-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes
dot-content let-thumbnailcomponent in the Binary field.ESCwithout closing the entire dialogVideos
Thumbnail
use-dot-contentlet-thumbnail-component.mov
File Editing
open-editor-on-click-and-close-editor-on-escape.mov