Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(edit-content): Thumbnail in the Binary Preview Punchlist #26907 #27160

Conversation

rjvelazco
Copy link
Contributor

@rjvelazco rjvelazco commented Jan 3, 2024

Changes

  1. Use the correct thumbnail path (/dA/<%=inode%>/500mw/20q/<%=fileName%>)
  2. Add pdf thumbnail.
  3. Implement new attribute editableAsText.
  4. Update font size in Monaco editor from 12px to 14px.
  5. Show File Size in kb/mb/gb to be human-friendly.

Thumbanils

Image

image-thumbnail.mov

image-path

PDF

pdf-thumbnail.mov

Video

video-thumbnail.mov

Editable File

editable-file.mov

Edit Image (Legacy)

edit-image-legacy.mov

Editing an image multiple times

edit-image-legacy.mov

@rjvelazco rjvelazco marked this pull request as ready for review January 5, 2024 16:57
@rjvelazco rjvelazco marked this pull request as draft January 5, 2024 17:28
@rjvelazco rjvelazco linked an issue Jan 8, 2024 that may be closed by this pull request
@rjvelazco rjvelazco self-assigned this Jan 8, 2024
@rjvelazco rjvelazco marked this pull request as ready for review January 8, 2024 15:35
@rjvelazco rjvelazco requested a review from zJaaal January 9, 2024 20:18
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@fmontes fmontes changed the title Edit Content: Thumbnail in the Binary Preview Punchlist chore(edit-content): Thumbnail in the Binary Preview Punchlist Jan 10, 2024
@fmontes fmontes changed the title chore(edit-content): Thumbnail in the Binary Preview Punchlist chore(edit-content): Thumbnail in the Binary Preview Punchlist #26907 Jan 10, 2024
@fmontes fmontes added this pull request to the merge queue Jan 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2024
@fmontes fmontes added this pull request to the merge queue Jan 10, 2024
Merged via the queue into master with commit 791bf1f Jan 10, 2024
41 checks passed
@fmontes fmontes deleted the issue-26907-edit-content-thumbnail-in-the-binary-preview-punchlist branch January 10, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit Content: Thumbnail in the Binary Preview Punchlist
3 participants