Fix #26846: Edit Ema copy url and api link buttons #26905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps://github.com/dotCMS/core into 26821-edit-ema-add-menu-to-select-page-language
…ps://github.com/dotCMS/core into 26821-edit-ema-add-menu-to-select-page-language
…ps://github.com/dotCMS/core into 26821-edit-ema-add-menu-to-select-page-language
…sona-selector/edit-ema-persona-selector.component.spec.ts Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>
zJaaal
requested review from
fmontes,
oidacra,
manuelrojas,
hmoreras,
rjvelazco and
KevinDavilaDotCMS
Closed
oidacra
reviewed
Dec 7, 2023
oidacra
reviewed
Dec 7, 2023
...ot-ema/src/lib/components/edit-ema-language-selector/edit-ema-language-selector.component.ts
Outdated
Show resolved
Hide resolved
oidacra
reviewed
Dec 7, 2023
.../dot-ema/src/lib/components/edit-ema-persona-selector/edit-ema-persona-selector.component.ts
Outdated
Show resolved
Hide resolved
fmontes
requested changes
Dec 7, 2023
core-web/libs/portlets/dot-ema/src/lib/feature/dot-ema.component.html
Outdated
Show resolved
Hide resolved
core-web/libs/portlets/dot-ema/src/lib/feature/store/dot-ema.store.ts
Outdated
Show resolved
Hide resolved
fmontes
approved these changes
Dec 8, 2023
|
0.0% Coverage on New Code
0.0% Duplication on New Code
manuelrojas
approved these changes
Dec 11, 2023
rjvelazco
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖[deprecated] Generated by Copilot at 8293ce1
Summary
🚚🎨🛠️
This pull request updates the style and functionality of some components related to the dot-ema portlet. It adds a new persona selector component that uses a listbox and an avatar directive. It also enhances the language selector component to use a listbox and a native button. It moves the avatar directive to a new location and updates the imports in several files. It changes the border color of the toolbar component and removes some unused styles.
Walkthrough
DotAvatarDirectivefrom@directives/dot-avatar/dot-avatar.directiveto@dotcms/uiin several files to use the new location of the directive (link, link, link, link, link, link, link, link).Screenshots
Screen.Recording.2023-12-06.at.6.22.41.PM-1.mov