Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#23971 IPUtils Test failure from incorrect state of IPUtils.disabledIpPrivateSubnet #23972

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

spbolton
Copy link
Contributor

@spbolton spbolton commented Jan 31, 2023

Fix for #23971

@github-actions
Copy link

github-actions bot commented Jan 31, 2023

Unit Tests Report

1 418 tests  ±0   1 408 ✔️ +1   3m 58s ⏱️ -1s
   140 suites ±0        10 💤 ±0 
   140 files   ±0          0  - 1 

Results for commit acc4ec2. ± Comparison against base commit eb4e08a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 31, 2023

Postman Tests Report

    1 files   -   53  137 suites   - 596   31m 17s ⏱️ - 1h 1m 38s
  45 tests  - 317    45 ✔️  - 316  0 💤 ±0  0  - 1 
157 runs   - 961  157 ✔️  - 956  0 💤 ±0  0  - 5 

Results for commit acc4ec2. ± Comparison against base commit eb4e08a.

This pull request removes 362 and adds 45 tests. Note that renamed tests count towards both.
AddRemoveContentletFromAPage ‑ Status code should be ok 200
AddRemoveContentletFromAPage ‑ Variants with correct weight
ApiTokenResource ‑ Status code is 200
ApiTokenResource ‑ Status code should be 200
ApiTokenResource ‑ Status code should be 400
ApiTokenResource ‑ Status code should be 401
ApiTokenResource ‑ Status code should be 403
ApiTokenResource ‑ Status code should be 404
ApiTokenResource ‑ User Id should be dotcms.org.1
Apps ‑ Status code is 200
…
GraphQl ‑ 'Containers Field' includes all Container Structures
GraphQl ‑ 'DotAssetBaseTypeCollection' includes all fields
GraphQl ‑ 'FileBaseTypeCollection' includes all fields
GraphQl ‑ 'KeyValueBaseTypeCollection' includes all fields
GraphQl ‑ 'Page' includes all properties
GraphQl ‑ 'PageBaseTypeCollection' includes all fields
GraphQl ‑ 'PersonaBaseTypeCollection' includes all fields
GraphQl ‑ 'QueryMetadata' includes all fields
GraphQl ‑ 'Site' element includes all properties
GraphQl ‑ 'VanityURLBaseTypeCollection' includes all fields
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Integration Tests [postgres] Report

   426 files  ±0     426 suites  ±0   1h 1m 54s ⏱️ - 7m 39s
4 571 tests ±0  4 545 ✔️ ±0  23 💤 ±0  3 ±0 
4 610 runs  ±0  4 584 ✔️ ±0  23 💤 ±0  3 ±0 

For more details on these failures, see this check.

Results for commit 545d762. ± Comparison against base commit 6590a84.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Integration Tests [mssql] Report

0 files   -    425  0 suites   - 425   0s ⏱️ - 2h 46m 49s
0 tests  - 4 566  0 ✔️  - 4 523  0 💤  - 23  0  - 20 
0 runs   - 4 605  0 ✔️  - 4 562  0 💤  - 23  0  - 20 

Results for commit 545d762. ± Comparison against base commit 6590a84.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@wezell wezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@wezell wezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@spbolton spbolton force-pushed the bug-23917-ip-subnet-unit-test-failure branch from 545d762 to acc4ec2 Compare February 2, 2023 21:21
@dotcms-sonarqube
Copy link

@spbolton spbolton merged commit 4ae86c5 into master Feb 2, 2023
@spbolton spbolton deleted the bug-23917-ip-subnet-unit-test-failure branch February 2, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants