Add comprehensive workflow linting and YAML auto-formatting infrastructure

[spbolton]

Description

Implement complete workflow linting infrastructure with yamllint and actionlint, add prettier auto-formatting for YAML files, integrate with pre-commit hooks and CI/CD pipeline, and establish clean formatting baseline for all 55+ workflow files.

Acceptance Criteria

• [Define what needs to be accomplished]

Additional Notes

[Any additional context or notes]

[spbolton]

Implementation Summary

This task has been completed in commit 05a631914b on branch workflow-linting.

What Was Implemented

1. Linting Infrastructure

• ✅ Added .yamllint configuration for YAML syntax validation
• ✅ Added .github/actionlint.yaml for GitHub Actions semantic validation
• ✅ Added mise.toml configuration for tool management (actionlint v1.7.8, yamllint)
• ✅ Created comprehensive linting strategy documentation (docs/core/LINTING_STRATEGY.md - 640 lines)

2. Auto-Formatting System

• ✅ Added .prettierrc.yml for workflow-specific formatting rules
  • printWidth: 120, tabWidth: 2, singleQuote: true
  • Applies to .github/workflows/*.yml, .github/actions/**/action.yml
• ✅ Integrated prettier auto-formatting into pre-commit hook
• ✅ Two-tier validation: prettier (auto-fix) → yamllint (validate) → actionlint (semantic)

3. Pre-Commit Hook Enhancements

• ✅ Auto-format YAML files before validation
• ✅ Run yamllint and actionlint on staged workflow files
• ✅ Graceful degradation when tools are missing
• ✅ Re-stage auto-formatted files automatically
• ✅ Conditional execution (only runs when workflow files change)

4. CI/CD Integration

• ✅ Added workflow-lint job to PR validation (.github/workflows/cicd_1-pr.yml)
• ✅ Conditional execution based on workflow file changes
• ✅ Updated change detection filters (.github/filters.yaml)
• ✅ Updated initialize phase to detect workflow changes

5. Workflow Fixes (47 Issues Resolved)

• ✅ Fixed all script injection vulnerabilities (use env vars for untrusted input)
• ✅ Updated deprecated actions:
  • actions/checkout@v3 → @v4
  • actions/setup-python@v4 → @v5
  • aws-actions/configure-aws-credentials@v1 → @v4
• ✅ Updated custom actions from node16 to node20
• ✅ Fixed undefined inputs and invalid references
• ✅ Fixed input default values not matching options
• ✅ Removed 76 trailing spaces across all workflows
• ✅ Normalized spacing and indentation

6. Formatting Baseline

• ✅ Formatted all 55 workflow and action files with prettier
• ✅ Established clean baseline for future development
• ✅ 0 actionlint errors
• ✅ 0 yamllint errors
• ⚠️ 108 yamllint warnings (acceptable line-length issues for URLs/JSON/bash)

7. Documentation

• ✅ Updated docs/core/CICD_PIPELINE.md with workflow linting section (+131 lines)
• ✅ Created docs/core/LINTING_STRATEGY.md (comprehensive 640-line guide)
  • Complete linting strategy review across all layers
  • Git hook, frontend, backend, and CI/CD linting analysis
  • Gap analysis and recommendations for backend Java linting
  • Migration strategy for enabling additional linting tools

Files Changed

• 66 files changed
• 1,512 insertions, 548 deletions

Key Benefits

• Prevention: Catches workflow errors before merge
• Automation: Auto-fixes formatting issues before commit
• Consistency: Ensures uniform YAML formatting across project
• Speed: Developers get immediate feedback locally
• Quality: Reduces manual code review overhead
• Security: Detects script injection vulnerabilities
• Maintenance: Identifies deprecated actions and patterns

Testing

# Verify linting tools work
mise exec -- yamllint .github/workflows/cicd_1-pr.yml
mise exec -- actionlint .github/workflows/cicd_1-pr.yml

# Test pre-commit hook
git add .github/workflows/test.yml
git commit -m "test"  # Triggers auto-formatting and validation

Related Documentation

• CI/CD Pipeline Documentation
• Linting Strategy Guide

Branch

workflow-linting - Ready for review and merge

[spbolton]

This work has been completed in commit 05a6319 on branch workflow-linting. All linting infrastructure, auto-formatting, pre-commit hooks, CI/CD integration, and documentation are in place. Ready for review.

[spbolton]

This issue is being addressed in PR #33872