Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean Test Errors in Locales Portlet #30394

Closed
hmoreras opened this issue Oct 18, 2024 · 2 comments · Fixed by #30400
Closed

Clean Test Errors in Locales Portlet #30394

hmoreras opened this issue Oct 18, 2024 · 2 comments · Fixed by #30400
Assignees
@oidacra
Labels
Gardening Day QA : Passed Internal Team : Falcon Type : Enhancement

Comments

@hmoreras
Copy link
Contributor

hmoreras commented Oct 18, 2024 •
edited
Loading

Problem Statement

There are warnings appearing in the test run for this portlet, which need to be addressed to ensure proper functionality and maintain code quality.

Steps to Reproduce

For the test warnings:

  1. Run the test suite for the Locales portlet, nx run portlets-dot-locales-portlet:test
  2. Observe the console output or test report
  3. Note the warnings that appear during the test run https://gist.github.com/hmoreras/aedfd95812fbd26f901423d5e9048bcb

Acceptance Criteria

. Test Warnings:

  • All warnings in the test run for the Locales portlet should be resolved

dotCMS Version

latest

Proposed Objective

User Experience and Code Quality

Additional Notes

Related Issues
@hmoreras hmoreras self-assigned this Oct 18, 2024
@hmoreras hmoreras changed the title Cursor Style and Test Warnings in Locales Portlet Test Warnings in Locales Portlet Oct 18, 2024
@hmoreras hmoreras changed the title Test Warnings in Locales Portlet Clean Test Warnings in Locales Portlet Oct 18, 2024
@hmoreras hmoreras linked a pull request Oct 18, 2024 that will close this issue
implementation ( locales tests) : #30394 Clean Test Errors in Locales Portlet #30400
Merged
@hmoreras
Copy link
Contributor Author

QA note: Errors for this project are gone:

image

@hmoreras hmoreras changed the title Clean Test Warnings in Locales Portlet Clean Test Errors in Locales Portlet Oct 18, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 18, 2024
@hmoreras
implementation ( locales tests) : #30394 Clean Test Errors in Locales…
b5e54e2 
… Portlet (#30400)

### Proposed Changes
* We are having several errors while running the Locales Portlet,
https://gist.github.com/hmoreras/aedfd95812fbd26f901423d5e9048bcb
* following this approach:
primefaces/primeng#14085 (comment)



### Screenshots
<img width="1490" alt="image"
src="https://github.com/user-attachments/assets/d7882a5d-0a93-4308-af21-980df2289c70">
@oidacra
Copy link
Member

oidacra commented Oct 18, 2024

IQA, no more warnings when you run the project.

@oidacra oidacra self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oidacra oidacra

Labels
Gardening Day QA : Passed Internal Team : Falcon Type : Enhancement
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implementation ( locales tests) : #30394 Clean Test Errors in Locales Portlet dotCMS/core
2 participants
@oidacra @hmoreras