Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Locales] : Remove hyphens from Feature Flag name #30387

Closed
jcastro-dotcms opened this issue Oct 17, 2024 · 1 comment · Fixed by #30388
Closed

[Locales] : Remove hyphens from Feature Flag name #30387

jcastro-dotcms opened this issue Oct 17, 2024 · 1 comment · Fixed by #30388
Assignees
@dsilvam
Labels
dotCMS : Localization Includes i18n and multi-lingual issues Team : Falcon Type : Defect

Comments

@jcastro-dotcms
Copy link
Contributor

jcastro-dotcms commented Oct 17, 2024 •
edited
Loading

Parent Issue

Problem Statement

The hyphens present in the Feature Flag used for showing/hiding the old Languages portlet:

FEATURE_FLAG_LOCALES_HIDE-OLD-LANGUAGES-PORTLET

Are not working correctly when setting this as an env var. The hyphens must be replaced with underscores.

Steps to Reproduce

  • Start dotCMS with the latest Docker image.
  • Set the FF in false, like this:
DOT_FEATURE_FLAG_LOCALES_HIDE-OLD-LANGUAGES-PORTLET: 'false'
  • Go to the Roles & Tools portlet. You'll see that the 'Languages` portlet is still not showing up.

Acceptance Criteria

Setting the FF to false must display the Languages portlet in the dropdown. The corrected FF name is:

DOT_FEATURE_FLAG_LOCALES_HIDE_OLD_LANGUAGES_PORTLET

You can follo the same steps to reproduce from the parent ticket: #30300

dotCMS Version

Latest from main

Proposed Objective

Core Features

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@jcastro-dotcms jcastro-dotcms self-assigned this Oct 17, 2024
jcastro-dotcms added a commit that referenced this issue Oct 17, 2024
@jcastro-dotcms
feat(Locales) #30387 : Remove hyphens form Feature Flag name
3c05136
@github-actions GitHub Actions
Copy link

PRs:

@jcastro-dotcms jcastro-dotcms linked a pull request Oct 17, 2024 that will close this issue
feat(Locales) #30387 : Remove hyphens from Feature Flag name #30388
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 18, 2024
@jcastro-dotcms
feat(Locales) #30387 : Remove hyphens from Feature Flag name (#30388)
819640c 
### Proposed Changes
* Removing hyphens from Feature Flag name as they don't play well with
the env var naming convention.
@github-actions github-actions bot mentioned this issue Oct 18, 2024
Merged
@jcastro-dotcms jcastro-dotcms removed their assignment Oct 18, 2024
@dsilvam dsilvam removed the Triage label Oct 18, 2024
@dsilvam dsilvam self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsilvam dsilvam

Labels
dotCMS : Localization Includes i18n and multi-lingual issues Team : Falcon Type : Defect
Projects
dotCMS - Product Planning
Status: Internal QA
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Locales) #30387 : Remove hyphens from Feature Flag name dotCMS/core
2 participants
@dsilvam @jcastro-dotcms