Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Java21 arguments #29756

Closed
Tracked by #27993
spbolton opened this issue Aug 27, 2024 · 1 comment · Fixed by #29758
Closed
Tracked by #27993

Cleanup Java21 arguments #29756

spbolton opened this issue Aug 27, 2024 · 1 comment · Fixed by #29758
Labels
Merged QA : Approved QA : Passed Internal Release : 24.09.21 UVE // Java21 Team : Scout

Comments

@spbolton
Copy link
Contributor

spbolton commented Aug 27, 2024 •
edited
Loading

Fix up arguments removing now unsupported options.

--illegal-access=deny is essentially the default in java 21 so is no longer needed

[DOTCMS]OpenJDK 64-Bit Server VM warning: Options -Xverify:none and -noverify were deprecated in JDK 13 and will likely be removed in a future release.
[DOTCMS]OpenJDK 64-Bit Server VM warning: Ignoring option --illegal-access=deny; support was removed in 17.0
@spbolton spbolton changed the title fix sdkman version build arg not passed when creating deployment image Cleanup Java21 arguments update garbage collection to use ZGC Generational Aug 27, 2024
@spbolton spbolton changed the title Cleanup Java21 arguments update garbage collection to use ZGC Generational Cleanup Java21 arguments Aug 27, 2024
@spbolton spbolton self-assigned this Aug 27, 2024
@spbolton spbolton mentioned this issue Aug 27, 2024
Merged
3 tasks
@spbolton spbolton linked a pull request Aug 27, 2024 that will close this issue
chore: Cleanup Java21 arguments (#29756) #29758
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Aug 27, 2024
@spbolton
chore: Cleanup Java21 arguments (#29756) (#29758)
a40ca94 
### Proposed Changes
* Remove old Pre java 21 java arguments

### Checklist
- [ ] Tests
- [ ] Translations
- [ ] Security Implications Contemplated (add notes if applicable)

### Additional Info
Related to #29756 (Cleanup Java21 arguments).


### Screenshots
Original             |  Updated
:-------------------------:|:-------------------------:
** original screenshot **  |  ** updated screenshot **
@nollymar nollymar reopened this Aug 27, 2024
@jgambarios jgambarios self-assigned this Aug 27, 2024
@jgambarios jgambarios removed their assignment Aug 27, 2024
@spbolton spbolton mentioned this issue Aug 28, 2024
Closed
@bryanboza
Copy link
Member

Fixed, now the docker image is builded on JAVA 21 and we are able to run the system without any problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Merged QA : Approved QA : Passed Internal Release : 24.09.21 UVE // Java21 Team : Scout
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Cleanup Java21 arguments (#29756) dotCMS/core
4 participants
@jgambarios @spbolton @bryanboza @nollymar