Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility of Delete Button on Content Types Portlet in Community Edition #29473

Closed
bryanboza opened this issue Aug 6, 2024 · 6 comments · Fixed by #29502
Closed

Visibility of Delete Button on Content Types Portlet in Community Edition #29473

bryanboza opened this issue Aug 6, 2024 · 6 comments · Fixed by #29502

Comments

@bryanboza
Copy link
Member

bryanboza commented Aug 6, 2024

Problem Statement

In the Community Edition of the content management system, users have reported that the delete button is not visible on the content types portlet. This issue prevents users from deleting unwanted or obsolete content types, impacting their ability to manage content effectively.
https://github.com/user-attachments/assets/f4e7fc0b-4afa-4f8f-95c3-69b9c63cffd5

Steps to Reproduce

  • Log into the backend using the Community Edition.
  • Navigate to the content types portlet.
  • Attempt to locate the delete button for any content type.
  • Observe that the delete button is not visible, preventing the deletion of content types.

Acceptance Criteria

  • Visible Delete Button: Ensure that the delete button is visible and accessible on the content types portlet in the Community Edition.
  • Consistent Behavior: The delete button should function consistently across different content types, allowing users to delete content types as needed.
  • User Feedback: Provide feedback or confirmation when a content type is successfully deleted.

dotCMS Version

Tested on trunk // Docker // FF

Proposed Objective

Quality Assurance

Proposed Priority

Priority 2 - Important

@dcolina
Copy link
Contributor

dcolina commented Aug 12, 2024

Internal QA: Needs work.

The initial issue was fixed, because the word delete is shown but in the wrong way.

Image

You can see more detail in the following video.

Screen.Recording.2024-08-12.at.20.23.45.mov

@dcolina dcolina removed their assignment Aug 12, 2024
@zJaaal
Copy link
Contributor

zJaaal commented Aug 12, 2024

@dcolina
The issue you are showing is related to the main issue and I'm not able to reproduce this issue anymore. Would it be Browser cache?

I'm testing on this Docker Image: [dotcms/dotcms:trunk_5205ee6]

Screen.Recording.2024-08-12.at.4.06.37.PM.mov

@dcolina
Copy link
Contributor

dcolina commented Aug 13, 2024

@zJaaal I was using the docker image [dotcms/dotcms:trunk] and Google Chrome browser as an incognito. I have retested this time with the same docker image you have used [dotcms/dotcms:trunk_5205ee6] and Google Chrome browser as an incognito as well.

This time I noticed that the delete icon is displayed on the right (as expected), but I think the alt (tooltip) is missing some styling. I've been checking and found out that this behavior is due to my dock (size and position). If you can see, when I move the dock, the window can be fully maximized, so the alt is displayed correctly, otherwise it's not. This behavior is shown in the following video:

Screen.Recording.2024-08-13.at.11.49.24.mov

In particular I don't think it should be considered a bug, although it wouldn't be bad to take a look at it in the responsive part.

@zJaaal
Copy link
Contributor

zJaaal commented Aug 13, 2024

Hello @dcolina I was looking into that and I found out that it is a PrimeNG Issue which is the library we use for our UI Components primefaces/primeng#13169

We are currently on the same version that the issue that is being reported but we have a PR to update the version of the library #29057

I would say that we should wait for that to merge and see if it was fixed, since it is a bug inside the library itself.

@dcolina
Copy link
Contributor

dcolina commented Aug 13, 2024

As @zJaaal commented above the responsive behavior is going to be fixed in #29057.

Internal QA: Passed.

@bryanboza
Copy link
Member Author

Fixed, tested on trunk_761ef08 // Docker // FF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment