Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CICD: Fix JReleaser path mismatch in dotCLI Release Process #29375

Closed
dcolina opened this issue Jul 29, 2024 · 2 comments · Fixed by #29513
Closed

CICD: Fix JReleaser path mismatch in dotCLI Release Process #29375

dcolina opened this issue Jul 29, 2024 · 2 comments · Fixed by #29513
Labels
dotCMS : CLI Merged QA : Approved Release : 24.08.20 AI Fixed Release : 24.08.27 Custom templates and loggin fixes Team : Scout Type : CI/CD Type : Defect

Comments

@dcolina
Copy link
Contributor

dcolina commented Jul 29, 2024 •
edited
Loading

Parent Issue

Problem Statement

During the dotCLI release process, the binaries are missing from the GitHub release. The issue seems to be related to the JReleaser binary selector, which appears to be referencing directories that no longer exist. The current configuration expects directories like artifacts-osx-aarch_64, but in the CI/CD build workflow, the directories are being named differently, such as artifacts-macos-14.

Steps to Reproduce

  1. Initiate the release process for dotCLI.
  2. Observe that the binaries are missing in the GitHub release.

Acceptance Criteria

  • All expected binaries are correctly published to GitHub releases.
  • The JReleaser configuration correctly identifies and utilizes the existing directories.

dotCMS Version

N/A

Proposed Objective

Quality Assurance

Proposed Priority

Priority 2 - Important

External Links

N/A

Assumptions & Initiation Needs

  • This issue assumes that the paths configured in JReleaser need to match the output directories of the CI/CD build workflow.
  • Initiation requires access to both the JReleaser configuration and the CI/CD workflow settings.

Quality Assurance Notes & Workarounds

N/A

Sub-Tasks & Estimates

N/A
dcolina added a commit that referenced this issue Aug 8, 2024
@dcolina
#29375 Fixing cleanup-runner action. Cleanup docker does not apply on…
c15426c 
… macOS.
dcolina added a commit that referenced this issue Aug 8, 2024
@dcolina
#29375 Enabling cleanup-runner on cli-build-artifacts and cli-release…
1f77eac 
…-process.
dcolina added a commit that referenced this issue Aug 8, 2024
@dcolina
#29375 Adding platform key to the runners matrix on cli-build-artifacts.
a76dffd
@dcolina dcolina mentioned this issue Aug 8, 2024
Merged
@dcolina dcolina linked a pull request Aug 8, 2024 that will close this issue
fix: CICD Fix JReleaser path mismatch in dotCLI Release (#29375) #29513
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 12, 2024
@dcolina
fix: CICD Fix JReleaser path mismatch in dotCLI Release (#29375) (#29513
5da036f 
)

### Proposed Changes
* Fix cleanup-runner action. Docker commands are not available on macOS
runners.
* Enable cleanup-runner on `cli-build-artifacts` and
`cli-release-process` to avoid disk space issues.
* Setting the right path to get the cli binaries and pushing as
artifacts of the release.

### Additional Info
Related to #29375 (CICD Fix JReleaser path mismatch in dotCLI Release).
@dcolina dcolina removed their assignment Aug 13, 2024
@bryanboza
Copy link
Member

bryanboza commented Aug 13, 2024 •
edited
Loading

Note: We need wait until fire the release process in order to validate if this is working or not...

@nollymar
Copy link
Contributor

Working as expected https://github.com/dotCMS/core/releases/tag/dotcms-cli-24.08.20

@bryanboza bryanboza added QA : Approved Release : 24.08.27 Custom templates and loggin fixes labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dotCMS : CLI Merged QA : Approved Release : 24.08.20 AI Fixed Release : 24.08.27 Custom templates and loggin fixes Team : Scout Type : CI/CD Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: CICD Fix JReleaser path mismatch in dotCLI Release (#29375) dotCMS/core
3 participants
@bryanboza @nollymar @dcolina