Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Chip as Designed in the Design System #29188

Closed
Tracked by #28493
oidacra opened this issue Jul 10, 2024 · 0 comments · Fixed by #29204
Closed
Tracked by #28493

Implement Chip as Designed in the Design System #29188

oidacra opened this issue Jul 10, 2024 · 0 comments · Fixed by #29204

Comments

@oidacra
Copy link
Member

oidacra commented Jul 10, 2024

Parent Issue

#28493

User Story

As a front-end developer, I need to implement the chip component as designed in the design system. This involves changing the icon and positioning it to the left, ensuring compatibility with future versions of PrimeNG, and maintaining all existing functionalities, especially the delete feature.

Acceptance Criteria

  • Implement the chip component according to the design system specifications.
  • Change the icon and position it to the left of the chip.
  • Ensure all existing functionalities of the chip, including the delete feature, are maintained.
  • Consider creating a directive to manipulate the PrimeNG tag component if necessary.
  • Verify that the implementation is not deprecated in future PrimeNG versions (specifically PrimeNG 17).
  • Ensure the implementation is visually consistent with the design system.
  • Write unit tests to cover the new chip functionality.
  • Ensure the implementation does not introduce any new bugs or regressions.

Proposed Objective

User Experience Enhancement, Code Maintenance

Proposed Priority

Priority 2 - Important

dotCMS Version

master

External Links

Assumptions & Initiation Needs

Assuming the current implementation of the tag component can be modified to align with the design system. Access to the current codebase, design system documentation, and PrimeNG documentation is required.

Quality Assurance Notes & Workarounds

Quality assurance should verify that the new tag component is visually consistent with the design system and that all functionalities, especially the delete feature, are preserved. Ensure compatibility with future PrimeNG versions and handle any edge cases.

@oidacra oidacra changed the title Implement Tag as designed on the Design System Implement Tag as Designed in the Design System Jul 10, 2024
@oidacra oidacra changed the title Implement Tag as Designed in the Design System Implement Chip as Designed in the Design System Jul 10, 2024
@nicobytes nicobytes self-assigned this Jul 11, 2024
@nicobytes nicobytes linked a pull request Jul 11, 2024 that will close this issue
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Jul 17, 2024
### Parent Issue
#29188

### Proposed Changes
- Refactor chip styles
- Create outline and filled style
- Organize colors variables
- Apply shade and tint pattern for colors
- Changes to mantain legacy scss variables
- Use a CSS map to generate severities based on it.

### Checklist
- [x] Tests
- [x] Translations
- [x] Security Implications Contemplated (add notes if applicable)

### Additional Info
Applying the Design System to a Chip Component

![Screenshot 2024-07-16 at 3 40
34 PM](https://github.com/user-attachments/assets/c53f846e-0e25-4b6e-9bf2-503f2daee4bf)

### External Links
- PrimeNG documentation: [PrimeNG
15-lts](https://www.primefaces.org/primeng-v15-lts/installation)
- Design system Chip
[FIGMA](https://www.figma.com/design/7CzbMcGSbTIJjerWtcapAm/Design-System-2023?node-id=1340-26310)

### Video


https://github.com/user-attachments/assets/b7d90f99-012d-456f-a3c3-ba8fbc0cd556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants