Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locales: Save sorting in the main table. #29040

Closed
hmoreras opened this issue Jun 27, 2024 · 5 comments · Fixed by #29063 or #29119
Closed

Locales: Save sorting in the main table. #29040

hmoreras opened this issue Jun 27, 2024 · 5 comments · Fixed by #29063 or #29119
Labels
Gardening Day QA : Approved Release : 24.07.05 Bug Fixing Team : Falcon Type : Task

Comments

@hmoreras
Copy link
Contributor

hmoreras commented Jun 27, 2024 •
edited
Loading

Parent Issue

User Story

Preserve the sort order while in the session in the Locale table, so when the user returns to the page, they see the data sorted in the way they defined previously.

Acceptance Criteria

  • The sort order is preserved and applied when the user returns to the page.

dotCMS Version

master

Proposed Objective

Enhance user experience by preserving the sort order in the Locale table, allowing users to return to their preferred view without needing to re-sort the data.

Proposed Priority

to_define

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

to_define

Assumptions & Initiation Needs

to_define

Quality Assurance Notes & Workarounds

to_define

Sub-Tasks & Estimates
@hmoreras hmoreras mentioned this issue Jun 28, 2024
Closed
2 tasks
@hmoreras hmoreras self-assigned this Jun 28, 2024
@hmoreras
Copy link
Contributor Author

Findings:

  • Keep the sorting by session required attrs in the table: stateStorage="session" stateKey="state-locales-session"
  • the sortField and sortOrder in the table, present in other portlets and in the dot-listing-data-table, overwrite the stateStorage.

@hmoreras hmoreras linked a pull request Jun 28, 2024 that will close this issue
implementation (Locales): #29040 Save sorting in the main table #29063
Merged
pull bot pushed a commit to boost-entropy-java/core that referenced this issue Jun 29, 2024
@hmoreras
implementation (Locales): dotCMS#29040 Save sorting in the main table (…
8d0420b 
…dotCMS#29063)

### Proposed Changes
* remember order in the locale table only (for now).
@nicobytes nicobytes self-assigned this Jul 2, 2024
@hmoreras
Copy link
Contributor Author

hmoreras commented Jul 2, 2024 •
edited
Loading

QA Note:

  1. Go to Settings - Roles & Tools, System and add the Locales Toot in the menu.
image
  1. Go to http://localhost:8080/dotAdmin/#/locales
  2. Order the table by any column, leave the page and come back, the order should be preserved.

@nicobytes
Copy link
Contributor

works fine! @hmoreras

2024-07-02.15-20-29.mp4

@nicobytes nicobytes removed their assignment Jul 2, 2024
@josemejias11
Copy link
Contributor

Failed: Tested on trunk_54611c0, Docker, macOS 14.5, FF v126.0.1

Icon for Locale is not changing when the column is selected for sorting
Screenshot 2024-07-02 at 3 17 13 PM

@hmoreras hmoreras linked a pull request Jul 3, 2024 that will close this issue
implementation (locales): #29040 #28477 Locales feedback & preserve table sorting. #29119
Merged
@hmoreras hmoreras reopened this Jul 3, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 4, 2024
@hmoreras @nicobytes
implementation (locales): #29040 #28477 Locales feedback & preserve t…
eeca0f8 
…able sorting. (#29119)

### Proposed Changes
* Directive that preserve the order of a table when the user leave the
page, even when `sortField` or `sortOrder` are defined.
* QA feedback: regarding missing copy button tooltip. 
* QA feedback: Locale header don't show the icon when sorted.   



### Screenshots


https://github.com/dotCMS/core/assets/31667212/4ca4d80a-3f48-45bc-b724-b7607d7e4707

---------

Co-authored-by: Nicolas Molina Monroy <hi@nicobytes.com>
@github-actions github-actions bot mentioned this issue Jul 4, 2024
Merged
@hmoreras hmoreras removed their assignment Jul 4, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on trunk_eeca0f8, Docker, macOS 14.5, FF v126.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Gardening Day QA : Approved Release : 24.07.05 Bug Fixing Team : Falcon Type : Task
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
4 participants
@oidacra @nicobytes @hmoreras @josemejias11