You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Only log a warning when a package or class is not part of the whitelist. Currently, we are always logging which makes the warning a bit noisy
2024-06-11T03:53:37.1084938Z 03:53:37.023 f1 main WARN lang.Boolean - java.lang.Boolean should be included in the xstream white list
2024-06-11T03:53:37.1086704Z 03:53:37.026 f1 main WARN lang.Long - java.lang.Long should be included in the xstream white list
2024-06-11T03:53:37.1089097Z 03:53:37.027 f1 main WARN collect.ImmutableList$SerializedForm - com.google.common.collect.ImmutableList.SerializedForm should be included in the xstream white list
Steps to Reproduce
The XStreamHandler is used each time you import/export a bundle
Acceptance Criteria
The code should be refactored to include the suggested changes
Our test suites should run green
dotCMS Version
Trunk
Proposed Objective
Code Maintenance
Proposed Priority
Priority 3 - Average
External Links... Slack Conversations, Support Tickets, Figma Designs, etc.
No response
Assumptions & Initiation Needs
No response
Quality Assurance Notes & Workarounds
No response
Sub-Tasks & Estimates
No response
The text was updated successfully, but these errors were encountered:
Parent Issue
No response
Problem Statement
We recently made changes in the XStreamHandler class to support a new xstream version. However, there are some improvements we can make to the code:
Extract the whitelist array to a constant https://github.com/dotCMS/core/blob/master/dotCMS/src/main/java/com/dotcms/util/xstream/XStreamHandler.java#L36-L39
Only log a warning when a package or class is not part of the whitelist. Currently, we are always logging which makes the warning a bit noisy
Steps to Reproduce
The XStreamHandler is used each time you import/export a bundle
Acceptance Criteria
dotCMS Version
Trunk
Proposed Objective
Code Maintenance
Proposed Priority
Priority 3 - Average
External Links... Slack Conversations, Support Tickets, Figma Designs, etc.
No response
Assumptions & Initiation Needs
No response
Quality Assurance Notes & Workarounds
No response
Sub-Tasks & Estimates
No response
The text was updated successfully, but these errors were encountered: