Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't Import Page Assets using the export file #28306

Closed
erickgonzalez opened this issue Apr 19, 2024 · 2 comments · Fixed by #28662
Closed

Can't Import Page Assets using the export file #28306

erickgonzalez opened this issue Apr 19, 2024 · 2 comments · Fixed by #28662
Assignees
@dsolistorres
Labels
OKR : Customer Support Owned by Scott Priority : 2 High QA : Approved Release : 23.01.18 Included in LTS patch release 23.01.18 Release : 23.10.24 v11 Included in LTS patch release 23.10.24 v11 Release : 24.04.24 v3 Included in LTS patch release 24.04.24 v3 Release : 24.06.06 Bug Fixing Team : Bug Fixers Type : Defect

Comments

@erickgonzalez
Copy link
Contributor

Parent Issue

No response

Problem Statement

If you try to use the export tool to export all Page Assets and import it afterward it fails with the following error message "badType: url"

Steps to Reproduce

1- Export Page Asset contentlets using the Export Tool (the one under the 3 dots on the right).
2- Try to import that CSV.
3- Get the error

Acceptance Criteria

Import should work since it's using the Export file as it is.

Slash should be stripped from the URL when validating.

dotCMS Version

All LTS versions and Master.

Proposed Objective

Core Features

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

https://dotcms.zendesk.com/agent/tickets/116011

Assumptions & Initiation Needs

Here is the issue:

core/dotCMS/src/main/java/com/dotcms/content/elasticsearch/business/ESContentletAPIImpl.java

Line 8080 in 264995d

.equals(contentlet.getIdentifier())) {
it's appending the Slash, and it already comes in the url.

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@dsolistorres dsolistorres self-assigned this May 6, 2024
@erickgonzalez erickgonzalez mentioned this issue May 9, 2024
Closed
dsolistorres added a commit that referenced this issue May 24, 2024
@dsolistorres
fix (import): handle URL field for pages imported (#28306)
a038c38
dsolistorres added a commit that referenced this issue May 24, 2024
@dsolistorres
#28306 : removed deprecated field class use
1340b9e
dsolistorres added a commit that referenced this issue May 24, 2024
@dsolistorres
#28306 : added comment for integration test
b68694e
@erickgonzalez erickgonzalez linked a pull request May 28, 2024 that will close this issue
fix (import): handle URL field for pages imported (#28306) #28662
Merged
1 task
github-merge-queue bot pushed a commit that referenced this issue May 29, 2024
@dsolistorres @freddyDOTCMS @erickgonzalez
fix (import): handle URL field for pages imported (#28306) (#28662)
f28fc49 
### Proposed Changes
* This change will handle the URL field when importing pages to dotCMS
* The URL field will be split in folder parent path and asset name. For
example the URL "/parent1/parent2/test-page" will be used to import the
page to the folder "/parent1/parent2" with the name "test-page"
* If the import file contains the "hostFolder" field, it it points to a
folder instead of a site, that value will take precedence to set the
folder target for the imported page.

### Checklist
- [x] Tests

---------

Co-authored-by: freddyDOTCMS <147462678+freddyDOTCMS@users.noreply.github.com>
Co-authored-by: erickgonzalez <erick.gonzalez@dotcms.com>
spbolton pushed a commit that referenced this issue Jun 3, 2024
@dsolistorres @freddyDOTCMS
@erickgonzalez @spbolton
fix (import): handle URL field for pages imported (#28306) (#28662)
0ccf276 
### Proposed Changes
* This change will handle the URL field when importing pages to dotCMS
* The URL field will be split in folder parent path and asset name. For
example the URL "/parent1/parent2/test-page" will be used to import the
page to the folder "/parent1/parent2" with the name "test-page"
* If the import file contains the "hostFolder" field, it it points to a
folder instead of a site, that value will take precedence to set the
folder target for the imported page.

### Checklist
- [x] Tests

---------

Co-authored-by: freddyDOTCMS <147462678+freddyDOTCMS@users.noreply.github.com>
Co-authored-by: erickgonzalez <erick.gonzalez@dotcms.com>
@gortiz-dotcms
Copy link
Contributor

gortiz-dotcms commented Jun 3, 2024 •
edited
Loading

Passed Internal QA

No errors

Image

Import made successfully

Image

@bryanboza
Copy link
Member

Fixed, now we are able to import pages using the exported files without problems..

Tested on the latest trunk env // Docker

@erickgonzalez erickgonzalez added the Next LTS Release Shortlisted of issues that will be included in the upcoming LTS label Jun 7, 2024
erickgonzalez added a commit that referenced this issue Jun 13, 2024
@erickgonzalez
#28306 include in 23.01.18 LTS
ad66f9c
erickgonzalez added a commit that referenced this issue Jun 17, 2024
@erickgonzalez
#28306 include in 23.10.24 LTS
6fd622f
erickgonzalez added a commit that referenced this issue Jun 18, 2024
@erickgonzalez
#28306 include in 24.04.24 LTS
5331ca4
@erickgonzalez erickgonzalez added Release : 24.04.24 v3 Included in LTS patch release 24.04.24 v3 Release : 23.10.24 v11 Included in LTS patch release 23.10.24 v11 Release : 23.01.18 Included in LTS patch release 23.01.18 and removed Next LTS Release Shortlisted of issues that will be included in the upcoming LTS labels Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsolistorres dsolistorres

Labels
OKR : Customer Support Owned by Scott Priority : 2 High QA : Approved Release : 23.01.18 Included in LTS patch release 23.01.18 Release : 23.10.24 v11 Included in LTS patch release 23.10.24 v11 Release : 24.04.24 v3 Included in LTS patch release 24.04.24 v3 Release : 24.06.06 Bug Fixing Team : Bug Fixers Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix (import): handle URL field for pages imported (#28306) dotCMS/core
4 participants
@bryanboza @dsolistorres @erickgonzalez @gortiz-dotcms