Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always include the dependency reference in the push publishing manifest file #28214

Closed
swicken-dotcms opened this issue Apr 12, 2024 · 2 comments · Fixed by #29823
Closed

Always include the dependency reference in the push publishing manifest file #28214

swicken-dotcms opened this issue Apr 12, 2024 · 2 comments · Fixed by #29823
Assignees
@dsolistorres
Labels
LTS : Next Ticket that will be added to LTS OKR : Customer Support Owned by Scott QA : Approved Release : 24.10.02 Bug Fixing Team : Bug Fixers Type : Enhancement

Comments

@swicken-dotcms
Copy link
Contributor

swicken-dotcms commented Apr 12, 2024 •
edited by erickgonzalez
Loading

Parent Issue

No response

Problem Statement

When the manifest is generated, we add a column that shows what name/identifier caused that object to be considered a dependency of the bundle.

We do not populate that column if the object is excluded from the bundle by mod_date.

This makes it challenging to troubleshoot dependency chains, as other things may be included by dependency to that excluded object, and we do not know what the excluded object was a dependency of.

Steps to Reproduce

  1. Set up a push publishing environment with the demo starter
  2. Push the entire site, check the manifest, and you will see all of the dependency references added
  3. Save/publish one piece of content
  4. Push the entire site; only the modified content will have its dependency reference

Acceptance Criteria

Always include the dependency reference, column name is included by
Should look like this, with the last column populated for every row

image

Rename the column to 'Reason to be evaluated'.

dotCMS Version

master, all LTS versions

Proposed Objective

Customer Support

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

Related ticket: https://dotcms.zendesk.com/agent/tickets/115864

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@dsolistorres dsolistorres self-assigned this Aug 19, 2024
@dsolistorres dsolistorres self-assigned this Aug 28, 2024
dsolistorres added a commit that referenced this issue Aug 30, 2024
@dsolistorres
fix(push-publish): always include dependency reference in PP manifest (…
2b15261 
…#28214)
@dsolistorres dsolistorres mentioned this issue Aug 30, 2024
Merged
1 task
dsolistorres added a commit that referenced this issue Sep 18, 2024
@dsolistorres
#28214 : fixed test to add evaluate reason for dependency bundle test
921c87d
dsolistorres added a commit that referenced this issue Sep 18, 2024
@dsolistorres
#28214 : added missing comments
a879579
github-merge-queue bot pushed a commit that referenced this issue Sep 21, 2024
@dsolistorres @freddyDOTCMS
@hmoreras @wezell @dcolina @nicobytes @victoralfaro-dotcms @KevinDavilaDotCMS @kevindaviladev @jdotcms @fmontes @fabrizzio-dotCMS @spbolton @zJaaal @jgambarios @jcastro-dotcms @rjvelazco @nollymar @oidacra @valentinogiardino @gortiz-dotcms @erickgonzalez
Always include dependency reference in PP manifest (#29823)
b59cf7d 
Closes #28214

### Proposed Changes
* With this change the dependency reference is always included for all
the files listed in the bundle manifest, even if the files were excluded
from the bundle because of a filter or because the file wasn't changed
after the last PP.
* This allows to trace why every file was listed in the manifest even
when the file was excluded from the bundle that was sent to the receiver

### Checklist
- [x] Tests

---------

Co-authored-by: freddyDOTCMS <147462678+freddyDOTCMS@users.noreply.github.com>
Co-authored-by: Humberto Morera <31667212+hmoreras@users.noreply.github.com>
Co-authored-by: Will Ezell <will@dotcms.com>
Co-authored-by: Daniel Enrique Colina Rodríguez <daniel.colina@dotcms.com>
Co-authored-by: Nicolas Molina Monroy <hi@nicobytes.com>
Co-authored-by: Victor Alfaro <victor.alfaro@dotcms.com>
Co-authored-by: Kevin Davila <144152756+KevinDavilaDotCMS@users.noreply.github.com>
Co-authored-by: Kevin Davila <kfariid@gmail.com>
Co-authored-by: Jonathan <jonathan.sanchez@dotcms.com>
Co-authored-by: Freddy Montes <751424+fmontes@users.noreply.github.com>
Co-authored-by: Fabrizzio Araya <37148755+fabrizzio-dotCMS@users.noreply.github.com>
Co-authored-by: spbolton <steve.bolton@dotcms.com>
Co-authored-by: Jalinson Diaz <zjaaaldev@gmail.com>
Co-authored-by: Jonathan Gamba <jonathan.gamba@dotcms.com>
Co-authored-by: Jose Castro <jose.castro@dotcms.com>
Co-authored-by: Rafael Velazco <rjvelazco21@gmail.com>
Co-authored-by: Nollymar Longa <nollymar.longa@dotcms.com>
Co-authored-by: Arcadio Quintero <oidacra@gmail.com>
Co-authored-by: Valentino Giardino <77643678+valentinogiardino@users.noreply.github.com>
Co-authored-by: Geronimo Ortiz <geronimo.ortiz@dotcms.com>
Co-authored-by: erickgonzalez <erick.gonzalez@dotcms.com>
@gortiz-dotcms
Copy link
Contributor

gortiz-dotcms commented Sep 24, 2024 •
edited
Loading

Passed internal QA

Captura de pantalla 2024-09-24 a la(s) 11 38 38 a  m

@josemejias11
Copy link
Contributor

Approved: Tested on trunk_839cebb, Docker, macOS 14.5, FF v126.0.1

@erickgonzalez erickgonzalez added the LTS : Next Ticket that will be added to LTS label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsolistorres dsolistorres

Labels
LTS : Next Ticket that will be added to LTS OKR : Customer Support Owned by Scott QA : Approved Release : 24.10.02 Bug Fixing Team : Bug Fixers Type : Enhancement
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always include dependency reference in PP manifest dotCMS/core
5 participants
@dsolistorres @erickgonzalez @swicken-dotcms @josemejias11 @gortiz-dotcms