Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force HTML highlighting for .vtl files #28084

Closed
wezell opened this issue Mar 26, 2024 · 3 comments · Fixed by #29166
Closed

Force HTML highlighting for .vtl files #28084

wezell opened this issue Mar 26, 2024 · 3 comments · Fixed by #29166
Labels
Gardening Day LTS: Excluded Ticket that has been excluded from at least one LTS Merged OKR : User Experience Owned by Jason QA : Approved QA : Passed Internal Release : 24.04.24 v6 Included in LTS patch release 24.04.24 v6 Release : 24.07.19 Bug Fixing Team : Lunik Team : Scout Triage Type : New Functionality

Comments

@wezell
Copy link
Contributor

wezell commented Mar 26, 2024 •
edited
Loading

User Story

When editing a VTL using the new monaco editor in the system, it is important that I should get good syntax highlighting on my files. As there is no VTL setting for monaco, we should force the HTML syntax onto VTL files.

This is how it looks now:

Screenshot 2024-03-26 at 4 26 09 PM

Acceptance Criteria

I should see HTML color coded when looking at a VTL file

Proposed Objective

Technical User Experience

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@erickgonzalez erickgonzalez mentioned this issue Jul 8, 2024
Closed
valentinogiardino added a commit that referenced this issue Jul 9, 2024
@valentinogiardino
#28084 fix highlighting for .vtl files
a245837
@valentinogiardino valentinogiardino linked a pull request Jul 9, 2024 that will close this issue
#28084 fix force html highlighting for .vtl files #29166
Merged
valentinogiardino added a commit that referenced this issue Jul 10, 2024
@valentinogiardino
#28084 add default mimeType and extension
cede741
valentinogiardino added a commit that referenced this issue Jul 10, 2024
@valentinogiardino
#28084 add test coverage
cd63793
valentinogiardino added a commit that referenced this issue Jul 10, 2024
@valentinogiardino
#28084 fix test
c444067
github-merge-queue bot pushed a commit that referenced this issue Jul 10, 2024
@valentinogiardino
#28084 fix force html highlighting for .vtl files (#29166)
6eaf236 
### Proposed Changes
* Introduced logic to set the editor's language to HTML when editing VTL
files:

1. Extracted file extension logic into extractFileExtension.
2. Created setVelocityLanguage for .vtl file handling.
3. Moved language update logic for other extensions to
updateLanguageForFileExtension.
4. Extracted validateFileType logic to check file types in all cases.


### Screenshots

![html-highlighting-for-vtl-files](https://github.com/dotCMS/core/assets/77643678/04aa6902-487a-4536-8222-820edae4c453)
@github-actions github-actions bot mentioned this issue Jul 10, 2024
Merged
@valentinogiardino valentinogiardino removed their assignment Jul 10, 2024
@erickgonzalez erickgonzalez added the LTS : Next Ticket that will be added to LTS label Jul 11, 2024
@zJaaal zJaaal self-assigned this Jul 15, 2024
@zJaaal
Copy link
Contributor

zJaaal commented Jul 15, 2024

IQA Passed

Docker Image: [dotcms/dotcms:trunk_430f4c7]

Screenshot

Screen.Recording.2024-07-15.at.11.19.17.AM.mov

@zJaaal zJaaal closed this as completed Jul 15, 2024
@zJaaal zJaaal removed their assignment Jul 15, 2024
@bryanboza
Copy link
Member

Fixed, tested on trunk and now it is working as expected

Image

@erickgonzalez erickgonzalez added Next LTS Release Shortlisted of issues that will be included in the upcoming LTS LTS: Excluded Ticket that has been excluded from at least one LTS labels Jul 18, 2024
@erickgonzalez
Copy link
Contributor

Only for 24.04 LTS

@erickgonzalez erickgonzalez removed the LTS : Next Ticket that will be added to LTS label Jul 18, 2024
gortiz-dotcms added a commit that referenced this issue Jul 25, 2024
@gortiz-dotcms
#28084 include in LTS 24.04.24 LTS
f4c0458
@erickgonzalez erickgonzalez added Release : 24.04.24 v6 Included in LTS patch release 24.04.24 v6 and removed Next LTS Release Shortlisted of issues that will be included in the upcoming LTS labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Gardening Day LTS: Excluded Ticket that has been excluded from at least one LTS Merged OKR : User Experience Owned by Jason QA : Approved QA : Passed Internal Release : 24.04.24 v6 Included in LTS patch release 24.04.24 v6 Release : 24.07.19 Bug Fixing Team : Lunik Team : Scout Triage Type : New Functionality
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#28084 fix force html highlighting for .vtl files dotCMS/core
7 participants
@fmontes @wezell @bryanboza @erickgonzalez @nollymar @zJaaal @valentinogiardino