Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a better way to clearly notify broken master #27490

Closed
2 tasks
dsilvam opened this issue Jan 31, 2024 · 2 comments · Fixed by #28176
Closed
2 tasks

Find a better way to clearly notify broken master #27490

dsilvam opened this issue Jan 31, 2024 · 2 comments · Fixed by #28176

Comments

@dsilvam
Copy link
Contributor

dsilvam commented Jan 31, 2024

Parent Issue

No response

Task

Currently if master fails to build (e.g. failing tests) there's no clear visibility for the interested parties.
We need to find an effective way to communicate when this happens.

  • Create a new Slack channel for reporting the upon build failure in master. Name: master-build-status
  • Notify to this new channel when failures take place

Proposed Objective

Core Features

Proposed Priority

Priority 2 - Important

Acceptance Criteria

Upon master failing to build, have a clear and explicit message sent to the Slack channel

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@dsilvam
Copy link
Contributor Author

dsilvam commented Jan 31, 2024

Main reporting yaml here .github/workflows/build-report.yml making vars.SLACK_REPORT_CHANNEL conditional

@dsilvam dsilvam linked a pull request Apr 10, 2024 that will close this issue
victoralfaro-dotcms added a commit that referenced this issue Apr 11, 2024
victoralfaro-dotcms added a commit that referenced this issue Apr 11, 2024
@dsilvam dsilvam reopened this Apr 12, 2024
@dsilvam
Copy link
Contributor Author

dsilvam commented Apr 19, 2024

Let's pass it for now and will send back if this is not working as expected.

@dsilvam dsilvam closed this as completed Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants