Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Ema: Update ema next dotcms app #27302

Closed
Tracked by #26644
fmontes opened this issue Jan 10, 2024 · 5 comments · Fixed by #27309
Closed
Tracked by #26644

Edit Ema: Update ema next dotcms app #27302

fmontes opened this issue Jan 10, 2024 · 5 comments · Fixed by #27309
Assignees
@jdotcms
Labels
OKR : Core Features Owned by Will Priority : 3 Average QA : Approved Release : 24.03.1 Announcements Team : Lunik Type : Defect

Comments

@fmontes
Copy link
Member

fmontes commented Jan 10, 2024 •
edited
Loading

Parent

#26644

Problem Statement

Non-admin users are currently unable to use the new edit mode in dotCMS, because we are validating the route with the /apps endpoint and that endpoint have specific permissions.

Steps to Reproduce

  1. Set the ema next app.
  2. Give permission to user Chris to edit a page
  3. Login as Chris
  4. Attempt to access the new edit mode and see the endpoint fail

Acceptance Criteria

We need to create a new endpoint that can be enabled by the settings of the app and this endpoint needs to returns the site app settings.
jdotcms added a commit that referenced this issue Jan 10, 2024
@jdotcms
#27302 adding an endpoint to expose the ema 2 app config to be users
184f935
@jdotcms
Copy link
Contributor

jdotcms commented Jan 11, 2024

when not configuration
Screenshot 2024-01-11 at 8 54 37 AM

the result is
Screenshot 2024-01-11 at 8 54 31 AM

@jdotcms
Copy link
Contributor

jdotcms commented Jan 11, 2024

When config with Admin
Screenshot 2024-01-11 at 8 54 59 AM

the result is:
Screenshot 2024-01-11 at 8 55 13 AM

@jdotcms
Copy link
Contributor

jdotcms commented Jan 11, 2024

When trying with FE
Screenshot 2024-01-11 at 8 55 26 AM

@jdotcms
Copy link
Contributor

jdotcms commented Jan 11, 2024

When trying with limited BE user
Screenshot 2024-01-11 at 8 55 44 AM

Screenshot 2024-01-11 at 8 56 01 AM

the result is
Screenshot 2024-01-11 at 8 56 08 AM

@jdotcms jdotcms linked a pull request Jan 11, 2024 that will close this issue
feat(edit-ema): Update ema next dotcms app #27302 #27309
Merged
jdotcms added a commit that referenced this issue Jan 11, 2024
@jdotcms
#27302 minor fix and postman test
453bd04
jdotcms added a commit that referenced this issue Jan 12, 2024
@jdotcms
#27302 adding more postman test
eb5c944
jdotcms added a commit that referenced this issue Jan 12, 2024
@jdotcms
#27302 trying to fix the postman test
9df254b
jdotcms added a commit that referenced this issue Jan 16, 2024
@jdotcms
#27302 upd postman
941e501
jdotcms added a commit that referenced this issue Jan 16, 2024
@jdotcms
#27302 upd postman
2a94b2e
@zJaaal zJaaal mentioned this issue Jan 16, 2024
Closed
jdotcms added a commit that referenced this issue Jan 17, 2024
@jdotcms
#27302 fixing an issue with the yml
ebf6d12
github-merge-queue bot pushed a commit that referenced this issue Jan 17, 2024
@jdotcms
feat(edit-ema): Update ema next dotcms app #27302 (#27309)
6dac7ca 
* #27302 adding an endpoint to expose the ema 2 app config to be users

* #27302 minor fix and postman test

* #27302 adding more postman test

* #26227 fixing the postman test

* #27302 trying to fix the postman test

* #27302 upd postman

* #27302 upd postman

* #26227 fixing the postman test

* #26227 fixing the postman test

* #27302 fixing an issue with the yml
@bryanboza
Copy link
Member

Fixed, tested on master // Docker // FF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdotcms jdotcms

Labels
OKR : Core Features Owned by Will Priority : 3 Average QA : Approved Release : 24.03.1 Announcements Team : Lunik Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(edit-ema): Update ema next dotcms app #27302 dotCMS/core
3 participants
@fmontes @bryanboza @jdotcms