Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit EMA: Redirect to /pages when changing sites #27075

Closed
2 tasks done
Tracked by #26644
fmontes opened this issue Dec 19, 2023 · 1 comment · Fixed by #27080
Closed
2 tasks done
Tracked by #26644

Edit EMA: Redirect to /pages when changing sites #27075

fmontes opened this issue Dec 19, 2023 · 1 comment · Fixed by #27080
Assignees
@zJaaal
Labels
OKR : Core Features Owned by Will Priority : 3 Average Team : Lunik Type : New Functionality

Comments

@fmontes
Copy link
Member

fmontes commented Dec 19, 2023 •
edited by zJaaal
Loading

Parent

#26644

User Story

As a dotCMS user, I want to be able to change from site to site while editing the page and dotCMS should react accordingly.

Acceptance Criteria
Beta Give feedback

Proposed Objective

Core Feature

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.:

N/A

Assumptions & Initiation Needs

  • We have a siteService that allow us to listen for that change.

Quality Assurance Notes & Workarounds

N/A

Sub-Tasks & Estimates

N/A
@fmontes fmontes mentioned this issue Dec 19, 2023
Closed
@zJaaal zJaaal self-assigned this Dec 20, 2023
@zJaaal zJaaal linked a pull request Dec 20, 2023 that will close this issue
feat(edit-ema): #27075 Redirect to /pages when site changes #27080
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Dec 21, 2023
@zJaaal
feat(edit-ema): #27075 Redirect to /pages when site changes (#27080)
f76be9c 
* dev (dot-ema): add flow for creating contentlets on the fly

* small fix on nextJS to avoid breaking the app

* dev (dot-ema): add test cases

* add placeholder for broken images in activity

* solve feedback

* refactor (dot-ema): Now we always have the language_id in queryParams for adding a contentlet

* dev (dot-ema): Add Nav Bar

* dev (dot-ema): Move editor to a component and make basic routing

* Update edit-ema-editor.component.ts

* Update dot-ema.component.spec.ts

* fix merge conflicts

* Update edit-ema-navigation-bar.component.scss

* small refactor for navigation bar

* dev (dot-ema): add wrapper components for portlets

* architecture clean up

* add lazy load

* unnest nav bar styles

* Update edit-ema-navigation-bar.component.html

* Update edit-ema-navigation-bar.component.scss

* Update edit-ema-navigation-bar.component.spec.ts

* Update edit-ema-navigation-bar.component.html

* refactor to use svg instead of base64 for experiments icon

* center svg properly

* general clean up

* Update edit-ema-navigation-bar.component.scss

* add template builder to edit-ema

* Update dot-ema.component.scss

* cleaning before refactor

* Update edit-ema-editor.component.ts

* fix tests

* fix broken tests

* clean up

* move dotRouter can deactivate route and dependencies to libs

* add flow to autosave and force saving on leave for template builder

* small tweaks to template builder

* map containers for Template Builder

* add containersMap and small clean up

* fix and add test cases

* delete repeat of code

* migrate tests to jest

* fix after merge and solve related feedback

* fix tests of store

* fix sonarqube

* solve feedback

* add routing to pages on siteSwitch

* Update dot-ema-shell.component.spec.ts
@fmontes
Copy link
Member Author

fmontes commented Jan 4, 2024

If /pages doesn't exist, goes to first portlet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zJaaal zJaaal

Labels
OKR : Core Features Owned by Will Priority : 3 Average Team : Lunik Type : New Functionality
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(edit-ema): #27075 Redirect to /pages when site changes dotCMS/core
2 participants
@fmontes @zJaaal