Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncated SEO Titles need Ellipsis #26531

Closed
damen-dotcms opened this issue Oct 26, 2023 · 3 comments · Fixed by #29272
Closed

Truncated SEO Titles need Ellipsis #26531

damen-dotcms opened this issue Oct 26, 2023 · 3 comments · Fixed by #29272
Labels
Gardening Day QA : Approved QA : Passed Internal Release : 24.07.30 GraphQL Schemas Team : Scout Triage

Comments

@damen-dotcms
Copy link
Contributor

Screenshot_2023-10-26_16-39-07.png

Parent Issue

Problem Statement

Steps to Reproduce

Acceptance Criteria

dotCMS Version

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

Assumptions & Initiation Needs

Quality Assurance Notes & Workarounds

Sub-Tasks & Estimates

Reported by: Damen Gilland (damen.gilland@dotcms.com)

Source URL: https://dotcms-qa-master.dotcms.site/dotAdmin/#/edit-page/content?url=%2Fblog%2Fpost%2Fecotourism-in-costa-rica%3Fhost_id%3D48190c8c-42c4-46af-8d1a-0cd5db894797&language_id=1&host_id=48190c8c-42c4-46af-8d1a-0cd5db894797

Issue details: Open in Marker.io

Device typedesktop
BrowserFirefox 118.0
Screen Size2056 x 1329
OSOS X 10.15
Viewport Size2056 x 1200
Zoom Level100%
Pixel Ratio@​2x
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Jan 25, 2024
@damen-dotcms damen-dotcms removed the stale label May 7, 2024
@valentinogiardino valentinogiardino self-assigned this Jul 18, 2024
@valentinogiardino valentinogiardino mentioned this issue Jul 18, 2024
Merged
@valentinogiardino valentinogiardino linked a pull request Jul 18, 2024 that will close this issue
fix(seo): title and description truncation with ellipsis #26531 #29272
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 19, 2024
@valentinogiardino
fix(seo): title and description truncation with ellipsis #26531 (#29272)
3a05a30 
Fix SEO title and description truncation with ellipsis

### Proposed Changes
* Truncate SEO titles and descriptions with ellipsis after specified
character limits.
* Ensure consistent handling of SEO_LIMITS for title and description
truncation.

This PR fixes #26531

### Screenshots
<img width="1728" alt="Captura de pantalla 2024-07-18 a la(s) 14 41 56"
src="https://github.com/user-attachments/assets/45c0818e-901d-4897-808e-0c6944ec29c6">
<img width="1728" alt="Captura de pantalla 2024-07-18 a la(s) 14 42 10"
src="https://github.com/user-attachments/assets/19fd9e83-75a7-4f35-84b8-a63bb4c15799">
<img width="1728" alt="Captura de pantalla 2024-07-18 a la(s) 14 42 22"
src="https://github.com/user-attachments/assets/04f10393-c8e5-48fc-b7c1-499a3bbeb13a">
<img width="1728" alt="Captura de pantalla 2024-07-18 a la(s) 14 48 29"
src="https://github.com/user-attachments/assets/32c0cd48-c590-4e40-84cf-febe2502d6ae">
@valentinogiardino valentinogiardino removed their assignment Jul 19, 2024
@zJaaal zJaaal self-assigned this Jul 22, 2024
@zJaaal
Copy link
Contributor

zJaaal commented Jul 22, 2024

IQA Passed

Now we can see the ellipsis when the text needs to be truncated.

Docker Image: [dotcms/dotcms:trunk_b00ffaf]

Screenshot

Screen.Recording.2024-07-22.at.12.19.00.PM.mov

@zJaaal zJaaal removed their assignment Jul 22, 2024
@zJaaal zJaaal closed this as completed Jul 22, 2024
@bryanboza
Copy link
Member

Fixed, tested on trunk // Docker // FF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Gardening Day QA : Approved QA : Passed Internal Release : 24.07.30 GraphQL Schemas Team : Scout Triage
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(seo): title and description truncation with ellipsis #26531 dotCMS/core
6 participants
@bryanboza @nollymar @john-thomas-dotcms @zJaaal @valentinogiardino @damen-dotcms