Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused myspell jar and fix classloading issue #23960

Open
spbolton opened this issue Jan 31, 2023 · 0 comments
Open

Remove unused myspell jar and fix classloading issue #23960

spbolton opened this issue Jan 31, 2023 · 0 comments

Comments

@spbolton
Copy link
Contributor

spbolton commented Jan 31, 2023

The myspell dependency is no longer used, although one of its internal utils classes has been added to a couple of our classes. The repackaged myspell jar also included a version of ant that was not renamed and being relied upon for compiling DotSQLGeneratorTask and TexenTask that extends org.apache.tools.ant.Task. Adding ant to the war can cause issues which were exposed in a later cdi change in the pipeline. Tomcat includes its own catalina-ant.jar in its classpath that is used by jasper the JSP engine. Including ant can create a ClassNotFound exception. Ant is required for compilation therefore, we add ant back in but with compileOnly.

l If TexenTask and DotSQLGeneratorTask are not longer used they could be removed and the ant dependency with it.

@spbolton spbolton changed the title Remove unused myspell jar and fixx classloading issue Remove unused myspell jar and fix classloading issue Jan 31, 2023
spbolton pushed a commit that referenced this issue Jan 31, 2023
…s covering up and some imports to internal classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

3 participants