Cover the case for multiple binary fields in one content type

dotCMS · Aug 13, 2024 · e2eeb27 · e2eeb27
1 parent 983abb4
commit e2eeb27
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 10 deletions.
diff --git a/dotCMS/src/main/webapp/html/portlet/ext/contentlet/edit_contentlet_js_inc.jsp b/dotCMS/src/main/webapp/html/portlet/ext/contentlet/edit_contentlet_js_inc.jsp
@@ -731,12 +731,11 @@
         customEvent.initCustomEvent('ng-event', false, false, customEventDetail);
         document.dispatchEvent(customEvent);
 
+        const binaryCallbacks = Object.keys(window.binaryFieldCallbacksMap || {}).map(key => window.binaryFieldCallbacksMap[key]); // Get the callbacks in an array
 
-
-        if(window.setBinaryFieldInputs) {
-            setBinaryFieldInputs()
-        }
-
+        binaryCallbacks.forEach(callback => {
+            callback(); // To reload all binary fields
+        });
     }
 
     function refreshPermissionsTab(){

diff --git a/dotCMS/src/main/webapp/html/portlet/ext/contentlet/field/edit_field.jsp b/dotCMS/src/main/webapp/html/portlet/ext/contentlet/field/edit_field.jsp
@@ -116,6 +116,11 @@
     }
 </style>
 
+<script>
+var binaryCallbacksMap = {} // This is a map to store the callbacks for the binary fields, used to reload them when we publish or save a contentlet, look on dotCMS/src/main/webapp/html/portlet/ext/contentlet/edit_contentlet_js_inc.jsp on saveContentCallback function
+</script>
+
+
 <div class="fieldWrapper" >
     <div class="fieldName" id="<%=field.getVelocityVarName()%>_tag">
         <% if (hint != null) {%>
@@ -786,10 +791,6 @@
 
                     const identifier =  "<%=contentletIdentifier%>";
 
-
-
-
-
                     fetch(`/api/v1/content/${identifier}`, {
                         method: 'GET',
                         headers: {
@@ -879,7 +880,12 @@
                     })
                 };
 
-                setBinaryFieldInputs();
+                setBinaryFieldInputs(); // Initialize the binary Field
+
+                // This code covers the multiple binaries in a contentlet
+                if(!binaryCallbacksMap["<%=field.getVelocityVarName()%>"]) {
+                    binaryCallbacksMap["<%=field.getVelocityVarName()%>"] = setBinaryFieldInputs; // Register the function to be called when the contentlet is saved
+                }
             </script>
         <%}else{%>