-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for mutiple schemas #491
Draft
rkrishnasanka
wants to merge
17
commits into
dosco:master
Choose a base branch
from
rkrishnasanka:feature/multi-schema
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm starting to make some changes to the code documentation here. I'm including a bit of refactoring to make sure that things are more readable. - The code extensively uses the short variable names to the detriment of the readability. This compounds the problem of not having enough code documentation. - While golang recommends short variable names, the intention is to avoid long nested function calls and to avoid diverting the attention from the main logic of the program. However, even the main logic variables have really short names making it almost impossible to read.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1. Changed all type structs were Pascal Case 2. Expanded 2-3 character field names for structs 3. Tried removing redundant functions
* Updated the basic documentation example * Improving code clarity I'm starting to make some changes to the code documentation here. I'm including a bit of refactoring to make sure that things are more readable. - The code extensively uses the short variable names to the detriment of the readability. This compounds the problem of not having enough code documentation. - While golang recommends short variable names, the intention is to avoid long nested function calls and to avoid diverting the attention from the main logic of the program. However, even the main logic variables have really short names making it almost impossible to read. * Incremental renaming of variables in intro.go
…aphjin queries (dosco#468) * Updated the basic documentation example * Updated addTable function to create a new variable that would create the type that has not_null for id in the scenario where we query by ID * Update intro.go * Update intro.go * Update intro.go --------- Co-authored-by: Spacy <832235+dosco@users.noreply.github.com>
…with nulls first or last
…with nulls first or last
…e yaml (an array of strings) * Updated a variable c which a copy of a configuration file to make the code more readable.
rkrishnasanka
force-pushed
the
feature/multi-schema
branch
from
April 15, 2024 11:59
26a43bf
to
5530c2a
Compare
Deployment failed with the following error:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: