Remove default styling imports on HTML paste (facebook#2663)

* remove default styling imports on HTML paste * remove test
dosatross · Jul 20, 2022 · c85d94d · c85d94d
1 parent 97734dc
commit c85d94d
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 56 deletions.
diff --git a/packages/lexical-playground/__tests__/e2e/CopyAndPaste.spec.mjs b/packages/lexical-playground/__tests__/e2e/CopyAndPaste.spec.mjs
@@ -2179,44 +2179,6 @@ test.describe('CopyAndPaste', () => {
     );
   });
 
-  test('HTML Copy + paste text with background and text color', async ({
-    page,
-    isPlainText,
-  }) => {
-    test.skip(isPlainText);
-    await focusEditor(page);
-    const clipboardData = {
-      'text/html':
-        '<span style="font-size:11pt;font-family:Arial;color:#000000;background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre;white-space:pre-wrap;">Lorem </span><span style="font-size:11pt;font-family:Arial;color:#000000;background-color:#00ff00;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre;white-space:pre-wrap;">ipsum</span><span style="font-size:11pt;font-family:Arial;color:#000000;background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre;white-space:pre-wrap;"> ~</span><span style="font-size:11pt;font-family:Arial;color:#4a86e8;background-color:#ffe599;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre;white-space:pre-wrap;">color</span><span style="font-size:11pt;font-family:Arial;color:#000000;background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre;white-space:pre-wrap;">~ sit </span><span style="font-size:11pt;font-family:Arial;color:#ff0000;background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre;white-space:pre-wrap;">amet</span></b>',
-    };
-    await pasteFromClipboard(page, clipboardData);
-    await assertHTML(
-      page,
-      html`
-        <p
-          class="PlaygroundEditorTheme__paragraph PlaygroundEditorTheme__ltr"
-          dir="ltr">
-          <span data-lexical-text="true">Lorem</span>
-          <span
-            style="background-color: rgb(0, 255, 0);"
-            data-lexical-text="true">
-            ipsum
-          </span>
-          <span data-lexical-text="true">~</span>
-          <span
-            style="color: rgb(74, 134, 232); background-color: rgb(255, 229, 153);"
-            data-lexical-text="true">
-            color
-          </span>
-          <span data-lexical-text="true">~ sit</span>
-          <span style="color: rgb(255, 0, 0);" data-lexical-text="true">
-            amet
-          </span>
-        </p>
-      `,
-    );
-  });
-
   test('HTML Copy + paste text with subscript and superscript', async ({
     page,
     isPlainText,

diff --git a/packages/lexical/src/nodes/LexicalTextNode.ts b/packages/lexical/src/nodes/LexicalTextNode.ts
@@ -843,11 +843,6 @@ function convertSpanElement(domNode: Node): DOMConversionOutput {
   const hasUnderlineTextDecoration = span.style.textDecoration === 'underline';
   // Google Docs uses span tags + vertical-align to specify subscript and superscript
   const verticalAlign = span.style.verticalAlign;
-  // Google Docs uses span tags + color, background-color for coloring
-  const backgroundColor = span.style.backgroundColor;
-  const textColor = span.style.color;
-
-  //TODO: font-size and coloring of subscript & superscript
 
   return {
     forChild: (lexicalNode) => {
@@ -873,19 +868,6 @@ function convertSpanElement(domNode: Node): DOMConversionOutput {
         lexicalNode.toggleFormat('superscript');
       }
 
-      let cssString = '';
-
-      if (textColor && textColor !== 'rgb(0, 0, 0)') {
-        cssString += `color: ${textColor};`;
-      }
-      if (backgroundColor && backgroundColor !== 'transparent') {
-        cssString += `background-color: ${backgroundColor};`;
-      }
-
-      if (cssString !== '') {
-        lexicalNode.setStyle(cssString);
-      }
-
       return lexicalNode;
     },
     node: null,