This repository was archived by the owner on Jan 23, 2024. It is now read-only.
throw exception when event_type is push and the field deleted is true#318
Open
KeiichiHirobe wants to merge 1 commit intodora-team:mainfrom
Open
throw exception when event_type is push and the field deleted is true#318KeiichiHirobe wants to merge 1 commit intodora-team:mainfrom
KeiichiHirobe wants to merge 1 commit intodora-team:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub sends two events when refs are deleted.
One is Delete event and the other is Push event the field
deletedof which payload is true. And the fieldhead_commitof Push events payloads is null.So, we see
Unsupported GitHub event: 'delete'and'NoneType' object is not subscriptablemessages when git refs are deleted, and I think the latter message is a little surprising.I added a change to check whether the
deletedfield is true and skips parsing logic if true.