Skip to content

Bump the range of supported Ruby versions #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

naitoh
Copy link
Contributor

@naitoh naitoh commented Jan 16, 2025

Ruby 3.4 is out

1. add Bundled gems for Ruby 3.4

https://bugs.ruby-lang.org/issues/20187

It has already been backported to the 7-0-stable branch, but is not included in 7.0.8.7.

2. Specify concurrent-ruby 1.3.4 for Rails 7.0

concurrent-ruby 1.3.5 don't work on Rails 7.0

NameError:
uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger

See: ruby-concurrency/concurrent-ruby#1062

@naitoh naitoh marked this pull request as draft January 16, 2025 12:40
@naitoh naitoh marked this pull request as ready for review January 16, 2025 13:01
Copy link
Member

@nbulaj nbulaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can we please squash the commits into a single one? 🙏

## Ruby 3.4 is out
### 1. Add Bundled gems for Ruby 3.4

https://bugs.ruby-lang.org/issues/20187

It has already been backported to the 7-0-stable branch, but is not included in 7.0.8.7.
- https://github.com/rails/rails/blob/7-0-stable/activesupport/activesupport.gemspec#L41-L43
- https://github.com/rails/rails/blob/v7.0.8.7/activesupport/activesupport.gemspec

### 2. concurrent-ruby 1.3.5 don't work on Rails 7.0

> NameError:
>  uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger

See: ruby-concurrency/concurrent-ruby#1062
@naitoh naitoh force-pushed the add-ruby-3.4-to-testing-matrix branch from c3f351b to 7e9d635 Compare January 17, 2025 13:13
@naitoh
Copy link
Contributor Author

naitoh commented Jan 17, 2025

Can we please squash the commits into a single one? 🙏

I squashed these commits, thanks.

@nbulaj nbulaj merged commit de5fc4f into doorkeeper-gem:main Jan 17, 2025
21 checks passed
@naitoh naitoh deleted the add-ruby-3.4-to-testing-matrix branch January 17, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants