Handle trying authorization with client credentials #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to start a new authorization for an application with grant flow 'client_credentials' (which also has redirect_uri nil), the following error occurs: NoMethodError: undefined method `split' for nil:NilClass lib/doorkeeper/oauth/helpers/uri_checker.rb:66 valid_for_authorization? lib/doorkeeper/oauth/pre_authorization.rb:89 validate_redirect_uri lib/doorkeeper/validations.rb:13 block in validate lib/doorkeeper/validations.rb:12 each lib/doorkeeper/validations.rb:12 validate lib/doorkeeper/validations.rb:19 valid? lib/doorkeeper/oauth/pre_authorization.rb:32 authorizable? app/controllers/doorkeeper/authorizations_controller.rb:8 new Moving the validation for supporting grant flows up, prevents this error from happening (and shows an error message to the user, instead of a 500 Internal Server Error).
Here's an example of a CHANGELOG.md entry: - [#1402] Handle trying authorization with client credentials.Generated by 🚫 Danger |
nbulaj
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to start a new authorization for an application with grant
flow 'client_credentials' (which also has redirect_uri nil), the
following error occurs:
NoMethodError: undefined method `split' for nil:NilClass
lib/doorkeeper/oauth/helpers/uri_checker.rb:66 valid_for_authorization?
lib/doorkeeper/oauth/pre_authorization.rb:89 validate_redirect_uri
lib/doorkeeper/validations.rb:13 block in validate
lib/doorkeeper/validations.rb:12 each
lib/doorkeeper/validations.rb:12 validate
lib/doorkeeper/validations.rb:19 valid?
lib/doorkeeper/oauth/pre_authorization.rb:32 authorizable?
app/controllers/doorkeeper/authorizations_controller.rb:8 new
Moving the validation for supporting grant flows up, prevents this
error from happening (and shows an error message to the user, instead of
a 500 Internal Server Error).