Bump the range of supported Ruby and Rails versions #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sato11
force-pushed
the
bump-range-of-supported-ruby-versions
branch
2 times, most recently
from
1aadc76
to
58686f2
Compare
|
Forgot to mention it in the changelog. Added it 🙂 |
|
@sato11 could you please fix the conflicts? 🙏 Thanks! |
sato11
force-pushed
the
bump-range-of-supported-ruby-versions
branch
from
58686f2
to
dadbf9a
Compare
nbulaj
reviewed
Feb 1, 2023
.github/workflows/ci.yml
Outdated
| @@ -36,8 +36,6 @@ jobs: | |||
| exclude: | |||
| - ruby: 3.0 | |||
| gemfile: gemfiles/rails_5_2.gemfile | |||
There was a problem hiding this comment.
We can also drop Rails 5.0 and 5.2
There was a problem hiding this comment.
Right. Will commit it here since you mention it 👍
There was a problem hiding this comment.
@nbulaj How does it look to you now? 🙂
Ruby 3.2 is out and 2.6 has reached the EOL: https://www.ruby-lang.org/en/downloads/branches/ Also since Rails 5 has been dropped support for and corresponding gemfiles are now dispensable to ci.
sato11
force-pushed
the
bump-range-of-supported-ruby-versions
branch
from
dadbf9a
to
b810c44
Compare
sato11
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.2 is out and 2.6 has reached the EOL:
https://www.ruby-lang.org/en/downloads/branches/
Also since Rails 5 has been dropped support for and
corresponding gemfiles are now dispensable to ci.
This is a follow-up to what I have committed to doorkeeper gem in doorkeeper-gem/doorkeeper#1618. I guess it would be great if the CI setup mirrors what doorkeeper has just like #175 has achieved it.
As 2.6 is dropped from CI I'm including the change that bumps the required ruby version. What do you think?