Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webfinger now returns issuer location #172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sato11
Copy link
Contributor

@sato11 sato11 commented Jul 11, 2022

Also removes the definition of webfinger_url_options, as it now becomes irrelevant.

This closes #171. Detailed background is provided in the issue.

Removing configurability of webfinger_url_options can be non-trivial. However if we are going to let it stick around, some might feel that another option like provider_url_options is missing. I wouldn't prefer adding it, because these /.well-known stuff are supposed to be self-sufficient, unlike endpoints that #provider might return. How does that sound?

Also removes the definition of `webfinger_url_options`,
as it now becomes irrelevant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using root_url in #webfinger_response can violate specification
1 participant