Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix .well-known/openid-connect issuer {} #160 #161

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

fkowal
Copy link
Contributor

@fkowal fkowal commented Nov 12, 2021

issuer block introduced in #144 breaks the .well-known/openid-connect response

when configuring issuer using a block

Doorkeeper::OpenidConnect.configure do
  issuer do |resource_owner, application|
  ...
  end
end

the DiscoveryController.provider return a issuer: {}

this gives the user back the control

when configuring issuer using a block
Doorkeeper::OpenidConnect.configure do
  issuer do |resource_owner, application|
  ...
  end
end

the DiscoveryController.provider return a `issuer: {}`

this gives the user back the control
Copy link
Member

@nbulaj nbulaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nbulaj nbulaj merged commit d556dd9 into doorkeeper-gem:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants