Skip to content

Commit

Permalink
Don't support Doorkeeper >= 5.2
Browse files Browse the repository at this point in the history
  • Loading branch information
@toupeira
toupeira committed Sep 24, 2019
1 parent 4a4b773 commit 0284cfc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion doorkeeper-openid_connect.gemspec
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Gem::Specification.new do |spec|

spec.required_ruby_version = ">= 2.3"

spec.add_runtime_dependency 'doorkeeper', '>= 5.0'
spec.add_runtime_dependency 'doorkeeper', '>= 5.0', '< 5.2'
spec.add_runtime_dependency 'json-jwt', '~> 1.6'

spec.add_development_dependency 'rspec-rails'
Expand Down

3 comments on commit 0284cfc

@ansonhoyt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why the dependency is being held to Doorkeeper 5.1.

It don't see any open issues about 5.2 problems or see anything scary (to an ignorant me) in the Doorkeeper changelog.

@toupeira
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some breaking changes, see #83. I added an issue now for visibility: #88

It will probably take me a while to get around to this, any help would be appreciated 😀

@ansonhoyt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've subscribed :-)

Will take me a while too, but I'm open to testing and fixing problems I find. I've used this with a new Rails 6 app (it seems to mostly work).

Please sign in to comment.