Skip to content

Conversation

@shollifield
Copy link

Hello,

I worked to add an EditText module to your code. I am working through Hacktoberfest and new to contributing. I hope you find some of my code helpful! Your app was interesting and a really cool learning experience.

@doomers
Copy link
Owner

doomers commented Oct 9, 2017

#3

@doomers
Copy link
Owner

doomers commented Oct 9, 2017

have you tested it?
it is not working on my system.

@doomers
Copy link
Owner

doomers commented Oct 9, 2017

too many errors

@doomers
Copy link
Owner

doomers commented Oct 9, 2017

first of all, for converting edittext to string IP.getText().toString() instead to IP.toString()
and othera are small but shows you haven't checked it on your machine

@shollifield
Copy link
Author

I will have it fixed. I tried to test on my machine but hit a network error, it accepted the input so I figured there was an incompatibility with my mac.

@doomers
Copy link
Owner

doomers commented Oct 10, 2017

Nopes, getIP() function was giving null value.
have you checked it?
just fix this problem and all extra tags in Edittest in activity_main.xml and i will merge it.
Thanks for contributing mate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants