Skip to content

add solution 146 with java #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 23, 2018
Merged

add solution 146 with java #50

merged 5 commits into from
Oct 23, 2018

Conversation

zhng1456
Copy link
Contributor

add solution 146 with java

@yanglbme yanglbme self-requested a review October 23, 2018 07:22
Copy link
Member

@yanglbme yanglbme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哈喽,有几个小地方

文件请规范命名

  • Java 里 文件名与类名保持一致,首字母大写
    e.g.
Solution.java
  • README 文件命名请按照 GitHub 规范,README 全大写
    e.g.
README.md

代码请规范书写

适当的空格是必要的
e.g.(不止这一处)

// 不规范的写法
Node newNode=new Node(key,value);
 //接下来要考虑容量
if(map.size()<capacity){
    setHead(newNode);
    map.put(key,newNode);
}
// 规范的写法
Node newNode = new Node(key, value);
 // 接下来要考虑容量
if (map.size() < capacity) {
    setHead(newNode);
    map.put(key, newNode);
}

不妨修改一下😄

@yanglbme yanglbme added the need optimization Improvement request label Oct 23, 2018
@yanglbme yanglbme merged commit ecb45d1 into doocs:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need optimization Improvement request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants