Skip to content

Add 147 Solution (java) #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

Add 147 Solution (java) #153

wants to merge 15 commits into from

Conversation

Mrzhudky
Copy link
Contributor

Add 147 solution.java and README.md

Copy link
Member

@yanglbme yanglbme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mrzhudky 谢谢提交,这里有几个小问题想跟你说一下哈。

  1. 不要提交附加多余文件 .editorconfig
  2. 一些代码的缩进格式不对
  3. if/else, while 书写不规范
  4. 不要添加这一个 solution 而产生了 15 个 commits

我觉得你可以重新把最新的仓库 fork 到你的帐户下,clone 到本地,做出修改后 push 到你的帐户,然后再提个 PR。

虽然我指出了这些小地方,但我相信改起来是特别快的,加油噢,等你新的 PR。我先把这个 PR 关了。之后提交规范的话,我会把你加入到本项目的维护者中,跟其它小伙伴一起维护仓库哈~

while (tempIndex >= j && map.containsKey(matchedStr)) {
// 正确匹配到单词
HashMap<String,Integer> searched = new HashMap<>();
// 从后向前依次对比
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里及以下的代码缩进不对噢

@@ -0,0 +1,8 @@

root = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要添加多余文件噢

*/
class Solution {
public ListNode insertionSortList(ListNode head) {
if(head == null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所有的 if/else 的书写都不规范噢,希望可以改一下。

  • if 后面需要加一个空格,然后才开始左括号,比如
if (condition) {
    // statement here
} 

else 跟在上个 if 的 } 后面,用一个空格隔开。如

if (condition) {
    // statement here
} else {
    // statement here
}
  • while 与 if 的写法一样

@yanglbme yanglbme closed this Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants