feat: add expo config plugin #2218

pafry7 · 2023-01-26T15:32:01Z

Why

Currently, you cannot use react-native-iap with expo (at least on android), because you have to configure build.gradle. Building an android app results in the following error:

* What went wrong:
Could not determine the dependencies of task ':app:compileDebugJavaWithJavac'.
> Could not resolve all task dependencies for configuration ':app:debugCompileClasspath'.
   > Could not resolve project :react-native-iap.
     Required by:
         project :app
      > The consumer was configured to find an API of a component, preferably optimized for Android, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'debug', attribute 'com.android.build.api.attributes.AgpVersionAttr' with value '7.2.1'. However we cannot choose between the following variants of project :react-native-iap:
          - amazonDebugApiElements
          - playDebugApiElements
        All of them match the consumer attributes:
          - Variant 'amazonDebugApiElements' capability Quikś:react-native-iap:unspecified declares an API of a component, preferably optimized for Android, as well as attribute 'com.android.build.api.attributes.AgpVersionAttr' with value '7.2.1', attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'debug':
              - Unmatched attributes:
                  - Provides attribute 'com.android.build.api.attributes.ProductFlavor:store' with value 'amazon' but the consumer didn't ask for it
                  - Provides attribute 'com.android.build.gradle.internal.attributes.VariantAttr' with value 'amazonDebug' but the consumer didn't ask for it
                  - Provides a library but the consumer didn't ask for it
                  - Provides attribute 'org.jetbrains.kotlin.platform.type' with value 'androidJvm' but the consumer didn't ask for it
                  - Provides attribute 'store' with value 'amazon' but the consumer didn't ask for it
          - Variant 'playDebugApiElements' capability Quikś:react-native-iap:unspecified declares an API of a component, preferably optimized for Android, as well as attribute 'com.android.build.api.attributes.AgpVersionAttr' with value '7.2.1', attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'debug':
              - Unmatched attributes:
                  - Provides attribute 'com.android.build.api.attributes.ProductFlavor:store' with value 'play' but the consumer didn't ask for it
                  - Provides attribute 'com.android.build.gradle.internal.attributes.VariantAttr' with value 'playDebug' but the consumer didn't ask for it
                  - Provides a library but the consumer didn't ask for it
                  - Provides attribute 'org.jetbrains.kotlin.platform.type' with value 'androidJvm' but the consumer didn't ask for it
                  - Provides attribute 'store' with value 'play' but the consumer didn't ask for it
        The following variants were also considered but didn't match the requested attributes:
          - Variant 'amazonReleaseApiElements' capability Quikś:react-native-iap:unspecified declares an API of a component, preferably optimized for Android, as well as attribute 'com.android.build.api.attributes.AgpVersionAttr' with value '7.2.1':
              - Incompatible because this component declares a component, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'release' and the consumer needed a component, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'debug'
          - Variant 'amazonReleaseRuntimeElements' capability Quikś:react-native-iap:unspecified declares a runtime of a component, preferably optimized for Android, as well as attribute 'com.android.build.api.attributes.AgpVersionAttr' with value '7.2.1':
              - Incompatible because this component declares a component, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'release' and the consumer needed a component, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'debug'
          - Variant 'playReleaseApiElements' capability Quikś:react-native-iap:unspecified declares an API of a component, preferably optimized for Android, as well as attribute 'com.android.build.api.attributes.AgpVersionAttr' with value '7.2.1':
              - Incompatible because this component declares a component, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'release' and the consumer needed a component, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'debug'
          - Variant 'playReleaseRuntimeElements' capability Quikś:react-native-iap:unspecified declares a runtime of a component, preferably optimized for Android, as well as attribute 'com.android.build.api.attributes.AgpVersionAttr' with value '7.2.1':
              - Incompatible because this component declares a component, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'release' and the consumer needed a component, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'debug'

How

I've created config plugin that changes the content of both build.gradle files.

TODO

add AndroidX support,
make sure nothing is missing for the plugin to work properly when published

andresesfm · 2023-01-27T01:19:47Z

plugin/__tests__/fixtures/buildGradleFiles.ts

+    compileSdkVersion rootProject.ext.compileSdkVersion
+
+    defaultConfig {
+missingDimensionStrategy "store", "play"


Looks like these variables have some duplication, any thoughts on using a common template?

Agree that there is too much of it. In current unit tests implementation, we are passing initial build.gradle (part of it to be precise) to the function and comparing the result with the correct version. This is done 3 times, one for each paymentProvider. We could remove irrelevant lines and leave only lines close to defaultConfig. What do you think?

andresesfm · 2023-01-27T01:21:13Z

plugin/__tests__/fixtures/buildGradleFiles.ts

+        versionCode 34
+        versionName "1.16.2"


Are these arbitrary/ do they matter to the person building an expo app?

All files in the fixtures directory are used solely for testing and will only be utilized by a developer writing tests.

andresesfm · 2023-01-27T01:21:34Z

plugin/__tests__/fixtures/buildGradleFiles.ts

+}
+
+    defaultConfig {
+        applicationId 'com.test.withIAP'


should these be customizable?

This is only a part of some faked build.gradle file to ensure that properties are added correctly in tests. Content is irrelevant. Maybe we should add a comment that explains it?

andresesfm · 2023-01-27T01:27:29Z

Thank you for your contribution @pafry7. I added some simple comments/questions. Let me know what you think. Overall great work, thank you for the unit tests too

pafry7 · 2023-01-27T07:49:06Z

plugin/src/withIAP.ts

+
+const pkg = require('../../package.json');
+
+type PaymentProvider = 'Amazon AppStore' | 'both' | 'Play Store';


Do you think this naming is okay? I didn't put much effort into it.

Yes, that should be OK, Thank you for your contribution

pafry7 force-pushed the feat/add-expo-config-plugin branch from 5256a2b to 3da0250 Compare January 26, 2023 15:36

feat: add expo config plugin

bf5a080

pafry7 force-pushed the feat/add-expo-config-plugin branch from 3da0250 to bf5a080 Compare January 26, 2023 18:44

andresesfm reviewed Jan 27, 2023

View reviewed changes

pafry7 commented Jan 27, 2023

View reviewed changes

andresesfm merged commit 4710655 into dooboolab-community:main Jan 30, 2023

masanishi mentioned this pull request May 13, 2024

Build fails when adding config plugin in expo #2478

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add expo config plugin #2218

feat: add expo config plugin #2218

pafry7 commented Jan 26, 2023 •

edited

Loading

andresesfm Jan 27, 2023

pafry7 Jan 27, 2023

andresesfm Jan 27, 2023

pafry7 Jan 27, 2023

andresesfm Jan 27, 2023

pafry7 Jan 27, 2023

andresesfm commented Jan 27, 2023

pafry7 Jan 27, 2023

andresesfm Jan 30, 2023


		const pkg = require('../../package.json');

		type PaymentProvider = 'Amazon AppStore' \| 'both' \| 'Play Store';

feat: add expo config plugin #2218

feat: add expo config plugin #2218

Conversation

pafry7 commented Jan 26, 2023 • edited Loading

Why

How

TODO

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andresesfm commented Jan 27, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pafry7 commented Jan 26, 2023 •

edited

Loading