Read templates from fs.FS to allow for embedding #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow for embedding all the assets into the binary I want to be able
to configure the filesystem html/template reads from.
I'm not sure how to add tests for this since component.go have no direct
tests. To test out the behavior I used
replace
in the go.mod for therender example to see that it still worked as expected.
The new embedfs example shows the same example by swapping out the FS
to the embedded one so there's something to show how it's used. :)
I'm happy to add more tests to make it fit the project as this is a bit of a drive by PR since I wanted to solve a problem for me, and hacked it together to test if it could work :D