Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vi: Add Vietnamese translation #553

Draft
wants to merge 56 commits into
base: master
Choose a base branch
from
Draft

Conversation

huylenq
Copy link

@huylenq huylenq commented Aug 4, 2021

Heavily in-progress stuff.


Review the Contributing Guidelines

Before submitting a pull request, verify it meets all requirements in the Contributing Guidelines.

Translations

See the Contributing Guidelines. Verify you've:

  • Tagged the language maintainer
  • Prefixed the title with a language code
    • Example: "ja: Fix ..."

@huylenq huylenq changed the title Add Vietnamese translation vi: Add Vietnamese translation Aug 4, 2021
@longqua69
Copy link

Hi @huylenq

I'd like to join the Vietnamese translation team. Could you please help me?

Thanks & Best regards,

Anh Tran

@Hungsiro506
Copy link

Lets go.

@huylenq
Copy link
Author

huylenq commented Aug 6, 2021

@longqua69 , sure thing!
Added you along with @Hungsiro506 as collaborators on the huylenq/system-design-primer fork.

@longqua69
Copy link

@huylenq thanks for inviting me into the translation team. Let's collaborate.

Copy link

@longqua69 longqua69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I checked, it's good to merge these changes.

README-vi.md Outdated Show resolved Hide resolved
README-vi.md Show resolved Hide resolved
README-vi.md Outdated Show resolved Hide resolved
README-vi.md Outdated Show resolved Hide resolved
README-vi.md Outdated Show resolved Hide resolved
README-vi.md Outdated Show resolved Hide resolved
README-vi.md Show resolved Hide resolved
@huylenq
Copy link
Author

huylenq commented Aug 22, 2021

@longqua69 Great suggestions! I'm more than welcome for you to commit and push those over directly to https://github.com/huylenq/system-design-primer/tree/master (you're already a collaborator). Would be more efficient that way, I think.

@longqua69
Copy link

Hi @huylenq

Thanks for your invitation. I'll contribute to this project. I'm impressed with your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants