Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write word "Korean" in Korean language. #428

Closed
wants to merge 1 commit into from
Closed

Write word "Korean" in Korean language. #428

wants to merge 1 commit into from

Conversation

rinnierin
Copy link

@rinnierin rinnierin commented Jun 20, 2020 •
edited
Loading

Write word "Korean" in Korean language from Chinese characters.

HeartSaVioR
HeartSaVioR approved these changes Jul 1, 2020
View reviewed changes
Copy link

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (Just to be sure, I'm Korean. :) )

@HeartSaVioR
Copy link

Oh looks like this is duplicated with #340

@donnemartin
Copy link
Owner

@sweetmangosweet thank you! Fixed in prior PR: #340.

@donnemartin donnemartin closed this Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeartSaVioR HeartSaVioR HeartSaVioR approved these changes

Assignees
No one assigned
Labels
help wanted needs-review translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rinnierin @HeartSaVioR @donnemartin